Repository navigation
Conversation
Add a first-party rsync-upload composite action and wire deploy_main / deploy_version to it, keeping the existing SFTP_* secret names. Mark sftp-upload deprecated until staging confirms rsync. Document the swap briefly in CONTRIBUTING (rsync-only; Docker preview follows separately). Co-authored-by: jj.kavelaars <jj.kavelaars@nrc-cnrc.gc.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rsync-only change for #146: switch GitHub Actions production and branch (webtest) uploads from SFTP to a first-party
rsync-uploadaction.Colleagues asked to split this out of the mixed #162 PR. This PR is only the deploy transport swap. Docker local preview, mock deploy smoke, and secret-free CI preview tooling are intentionally not here — those come in a later PR.
Included
.github/actions/rsync-upload/composite (rsync over SSH)deploy_main.yamlanddeploy_version.yamlwired torsync-uploadSFTP_PROD_*,SFTP_STAGE_*)sftp-uploadkept but marked deprecated until staging confirms rsyncTest plan
rsync-uploadfor SSH key handling and--deletemirror behaviorSFTP_*secrets / inputssftp-uploadin a follow-upSandbox (fork CI): ijiraq#2