Repository navigation
docs(execution): describe Cancel as the way to stop a run - #6
Merged
Merged
Conversation
The service comments still said that closing the Run stream cancels the run and that Cancel was for other tabs. Since runs outlive their stream after Accepted, describe Cancel as how a client stops a run and ResumeRun as how it reattaches. Comment-only change; generated code is regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ExecutionServicecomments inexecution.protowere out of date:Cancelas a call made from another tab.Since #4, a run outlives its stream once
Acceptedhas been sent. The comments now say thatCancelis how a client stops a run, and thatResumeRunis how it reattaches to the output.Testing
buf lintandbuf generatepass.execution.connect.go,execution_pb.ts).Not verified
Nothing applies: the change touches comments only.