[hamazaspavetisyan]

Follow-up to #1377 (#1383). Based on the 1377-drop-library-xml branch; please review/merge that PR first. Only the last two commits belong to this PR.

With library.xml gone, two Book fields can no longer be stored anywhere: OPDS has no representation for them, and adding one was ruled out in #1377. This PR removes them from the API for libkiwix 15.

Removed public API

Removed	Notes
Book::getOrigId(), Book::setOrigId()	Only the library.xml reader ever set origId; it was not used by any known client (FeedFormat).
Book::getDownloadId(), Book::setDownloadId()	Nothing in libkiwix reads it. It was only saved to and restored from library.xml.

Behavior changes

None.

Library::getBookAttributeCounts() and Library::getBooksLanguagesWithCounts() used to skip books with an origId. Since no book can have one anymore, they now count every book, and their results are unchanged. These functions back getBooksCategories(), getBooksCreators(), getBooksPublishers(), getBooksLanguages() and the /catalog/v2/categories and /catalog/v2/languages feeds.

Impact

• kiwix-desktop: build break. It calls getDownloadId()/setDownloadId() 13 times to link a book to its running download. Since Drop library.xml support in libkiwix 15 (OPDS becomes the only library file format) #1377, that link is no longer saved across restarts anyway. Issue: Keep track of in-progress downloads without relying on Book::downloadId in the library file kiwix-desktop#1538. It has to be fixed before kiwix-desktop moves to libkiwix 15.
• kiwix-tools: not affected.
• java-libkiwix: to check whether its bindings expose any of the four removed methods.

Commits

1. Dropped Book::origId. Removes the getter, setter and field, and the origId checks in src/library.cpp.
2. Dropped Book::downloadId. Removes the getter, setter and field.

Testing

All 24 test suites pass on macOS. No test change was needed: once #1377 is in, no test uses either field.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.95%. Comparing base (2f2ad9b) to head (8411ec2).

Files with missing lines	Patch %	Lines
src/library.cpp	0.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##           1377-drop-library-xml    #1384      +/-   ##
=========================================================
+ Coverage                  45.88%   45.95%   +0.06%     
=========================================================
  Files                         58       58              
  Lines                       5067     5055      -12     
  Branches                    2588     2586       -2     
=========================================================
- Hits                        2325     2323       -2     
+ Misses                      1015     1007       -8     
+ Partials                    1727     1725       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[veloman-yunkan]

I think there is some misunderstanding with download id. My impression was that support for it had to be added to OPDS library format, instead of dropping it from kiwix::Book.

[hamazaspavetisyan]

I think there is some misunderstanding with download id. My impression was that support for it had to be added to OPDS library format, instead of dropping it from kiwix::Book.

The downloadId was introduced to address specific needs in kiwix-desktop. Adding it to OPDS is not a good idea, as the OPDS library is intended to be generic. Instead, kiwix-desktop can use other methods to identify locally downloaded files. Or you see other uses cases of it ?

[veloman-yunkan]

Instead, kiwix-desktop can use other methods to identify locally downloaded files.

That can be a solution but it has to be implemented first before ditching the previous approach.

[hamazaspavetisyan]

Instead, kiwix-desktop can use other methods to identify locally downloaded files.

That can be a solution but it has to be implemented first before ditching the previous approach.

Just did it

kiwix/kiwix-desktop#1543