Repository navigation
docs: use Component instead of deprecated RootComponent - #8
Merged
Merged
Conversation
Switch the README and examples to Component; RootComponent is deprecated and renders the same output. Also fix two README examples that silently did nothing: - "add annotations to a specific kind" now nests annotations under metadata - simple.jsonnet now matches the README example and extends (instead of replacing) the pod template metadata, so ObjectTemplateMeta reaches pods Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RootComponentis deprecated (9d27a3a), but the README and both examples still used it. This switches them toComponent. The rendered output of both examples is byte-identical, andadopt.goldenwas regenerated with no diff.While checking the README snippets, two of them turned out to do nothing:
annotations+directly underService+, so the annotation never showed up. It is now nested undermetadata+.ObjectTemplateMetaexample: it importsexamples/simple.jsonnet, which had drifted from the README example and usedtemplate+: { metadata: ... }. That replaced the pod template metadata, so the annotation never reached pods.simple.jsonnetis now identical to the README example (metadata+:/selector+:). Side effect: its pod template now also keeps the library's defaultkubectl.kubernetes.io/default-containerannotation.just testpasses.🤖 Generated with Claude Code