Repository navigation
fix(zfs): guard ARC efficiency percentages against a zero denominator - #641
Merged
bennetgallein merged 1 commit intoOct 5, 2026
Merged
Conversation
The script died with 'Illegal division by zero' when arcstats reported zero hits, misses or accesses, as on a cold or idle ARC, so no JSON was returned. anon_hits_percent guarded on its numerator instead of its divisor. Made with help from Claude
ahoogerhuis
marked this pull request as ready for review
September 26, 2026 16:18
bennetgallein
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snmp/zfs divides by arc_hits/arc_misses with no zero-guard - crashes on any host with zero hits or misses since last poll (e.g. right after boot). Guarded all three denominators, including a wrong-variable guard on anon_hits_percent.
Verified on a test box, not yet in production.
Developed with Claude's assistance; reviewed, I take responsibility for correctness.