Repository navigation
TEL-1072: emit auth, dispatch, ACK, CANCEL, rejection and BYE signaling events - #915
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alexlivekit
reviewed
Oct 23, 2026
Contributor
Author
follow up PRs: transfer, outbound.. I wanted to control the volume of the events for now |
hechen-eng
force-pushed
the
events-inbound
branch
from
October 23, 2026 20:42
565d7af to
6106e95
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alexlivekit
approved these changes
Oct 23, 2026
alexlivekit
left a comment
alexlivekit
left a comment
Contributor
There was a problem hiding this comment.
If outbound is a follow up PR, then we're happy.
hechen-eng
force-pushed
the
events-inbound
branch
from
October 24, 2026 00:57
1066083 to
ae713c8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. Inbound signaling events stop at the main setup steps. There is no event for the auth and dispatch lookups, the ACK, a CANCEL, a rejected INVITE or the BYE.
Change. Emit seven more events:
sip.invite.authorizedandsip.call.dispatched(lookup result and duration, from the existingget-authandeval-dispatchstage timers),sip.ack.received,sip.cancel.received,sip.rejected(every final non-2xx response to the INVITE),sip.bye.received(only the Reason header's protocol and cause, not its free text) andsip.bye.sent(outcome, status and response time).SignalingEventgetsDuration,DispatchRuleIDandWithPIN(a PIN call is dispatched twice), andResultnow means the outcome of the step.The SIP leg holds the call state, so ACK, CANCEL, rejections and our BYE are reported where they are sent or received, including rejections before a call exists. The ACK and CANCEL events are emitted after the call is signalled, because emitting can wait on the call state's lock during a flush. The shared
sendByenow returns the response and error; outbound ignores them.