Repository navigation
tweaks/console-shows-shelf-batches (TW-5u3b5y) - #32
Merged
Merged
Conversation
Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
The Fix board payload carries every batch with its list row and its members, so the console can draw a live batch as one card and name a member's batch by title. A recap target carries a batch's title, a related row and a search hit carry a shelf node's derived phase so a batch member can read batched wherever it is drawn, and a member's batch reference carries the branch and PR pages on a GitHub origin. TestVocabularyCoversEveryTransition covers the batch noun again. Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
Fix draws a live batch as one card in its own status column with its title, owner, member count, members, and highest member severity, and no longer lists a batched member in Ready. A batch has its own node page (Members, Gates, Backlinks, History), and a member's page reads Batched and names its batch, branch, and PR. Batched has its own glyph shape. Home reads the batch list, so an in-review batch is named while it waits on the merge, and the empty-queue block says All clear only while nothing is in review. In flight marks a batch row, search has a Batches section and tab, and batch events have phrases and tiers. A recovered bug, chore, or tweak draws its panel without an empty riders list or a blank branch and is listed on Home's Recovered reviews tab. ui/dist is rebuilt. Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
The console spec and the site's console page cover the batch card on Fix, the batch page, the batched member, Home's handling of a batch and of recovered shelf reviews, the Batches search section, and the batch event tiers. Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows shelf batches and recovered shelf reviews in the console (TW-5u3b5y). Follows TW-taq0ps (PR #31) and TW-3eo3s2 (PR #30).
Change
batchedglyph: two overlapping rings, distinct by shape in Explore's shelves and filter.TestVocabularyCoversEveryTransitioncovers the batch noun again.Behaviour change to review
Home's empty-queue headline changes for every noun, not only batches. When any node sits in review waiting on a merge, the block now reads "Nothing is waiting in the queue." with no tick, where it read "All clear — nothing waiting in the queue." before. The contract asks that Home never read All clear while a batch waits, and an in-review bug had the same problem. It is one conditional in
ui/src/components/AllClear.tsx.Go side
/api/work-itemsgainsbatches.activity.branch_urlandpr_urlon a GitHub origin.Not in this PR
console-fix-*and possiblyconsole-home-*are stale and were not reshot.Merge with a merge commit, not a squash, so
tiller synccan record the tweak done.Verification
tiller check tweakgreen: build, tests, lint. UI suite: 2407 tests pass,tsc --noEmitclean.ui/distrebuilt with Node 22.