Skip to content

tweaks/console-shows-shelf-batches (TW-5u3b5y) - #32

Merged
thegrubbsian merged 6 commits into
mainfrom
tiller/tweaks/console-shows-shelf-batches
Nov 20, 2026
Merged

thegrubbsian merged 6 commits into
mainfrom
tiller/tweaks/console-shows-shelf-batches

Conversation

@thegrubbsian

Copy link
Copy Markdown
Member

Shows shelf batches and recovered shelf reviews in the console (TW-5u3b5y). Follows TW-taq0ps (PR #31) and TW-3eo3s2 (PR #30).

Change

  • Fix: each live batch is one card in the column for its status, with title, owner, member count, highest severity, and its ready members as links. A ready member no longer has its own card in Ready. A proposed member keeps its card in Proposed with an "In batch" link, since it still needs triage. The toolbar counts batches.
  • Batch page: the standard node header with a Batch pill, state, gate ticks, owner, highest severity, branch, and PR. Tabs are Members, Gates, Backlinks, History. There is no Spec tab, because a batch has no contract of its own.
  • Member page: reads Batched, and names its batch with a link, the batch's status, branch, and PR.
  • batched glyph: two overlapping rings, distinct by shape in Explore's shelves and filter.
  • Home: an in-review batch is named in the block that lists nodes waiting on a merge, an owner's batch appears in In flight, and batch links in Up next, Needs you, and Just happened open the batch page.
  • Search: finds a batch by id, key, and title, with a Batches tab.
  • Events: batch events have phrases, the plural reads "batches", and a membership edit is bookkeeping, not a milestone. TestVocabularyCoversEveryTransition covers the batch noun again.
  • Recovered shelf reviews: a recovered bug, chore, or tweak shows its panel without an empty riders list or a blank branch row, and Home's Recovered reviews tab lists it.

Behaviour change to review

Home's empty-queue headline changes for every noun, not only batches. When any node sits in review waiting on a merge, the block now reads "Nothing is waiting in the queue." with no tick, where it read "All clear — nothing waiting in the queue." before. The contract asks that Home never read All clear while a batch waits, and an in-review bug had the same problem. It is one conditional in ui/src/components/AllClear.tsx.

Go side

  • /api/work-items gains batches.
  • A batch has a title in recap targets and related rows.
  • Related rows and search hits carry a shelf node's activity.
  • A member's batch reference carries branch_url and pr_url on a GitHub origin.

Not in this PR

  • Explore's navigator has no Batches shelf, and Report has no batch rows.
  • A recovered bug before sync still sits in Fix's Ready column with a Recovered chip.
  • The recovered-review panel prints the recorder's contributor id, not the display name.
  • A member joining and leaving a batch share one event type, so both read "batch changed".
  • Site screenshots console-fix-* and possibly console-home-* are stale and were not reshot.

Merge with a merge commit, not a squash, so tiller sync can record the tweak done.

Verification

  • tiller check tweak green: build, tests, lint. UI suite: 2407 tests pass, tsc --noEmit clean. ui/dist rebuilt with Node 22.
  • Driven in Playwright WebKit against a scratch project with batches in every status, batched members of each noun, and a recovered bug before and after sync. Fix, the batch page, member pages, Home, History, Search, Explore, and Report were checked at 1440px and 390px with no console errors or failed requests. One narrow-viewport defect was found and fixed: batch member titles collapsed at 390px.
  • Not checked in Safari itself.

Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
The Fix board payload carries every batch with its list row and its members,
so the console can draw a live batch as one card and name a member's batch by
title. A recap target carries a batch's title, a related row and a search hit
carry a shelf node's derived phase so a batch member can read batched wherever
it is drawn, and a member's batch reference carries the branch and PR pages on
a GitHub origin.

TestVocabularyCoversEveryTransition covers the batch noun again.

Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
Fix draws a live batch as one card in its own status column with its title,
owner, member count, members, and highest member severity, and no longer lists
a batched member in Ready. A batch has its own node page (Members, Gates,
Backlinks, History), and a member's page reads Batched and names its batch,
branch, and PR. Batched has its own glyph shape.

Home reads the batch list, so an in-review batch is named while it waits on
the merge, and the empty-queue block says All clear only while nothing is in
review. In flight marks a batch row, search has a Batches section and tab, and
batch events have phrases and tiers. A recovered bug, chore, or tweak draws
its panel without an empty riders list or a blank branch and is listed on
Home's Recovered reviews tab.

ui/dist is rebuilt.

Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
The console spec and the site's console page cover the batch card on Fix, the
batch page, the batched member, Home's handling of a batch and of recovered
shelf reviews, the Batches search section, and the batch event tiers.

Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
Signed-off-by: JC Grubbs <grubbs.jc@gmail.com>
@thegrubbsian
thegrubbsian merged commit 1b40362 into main Nov 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant