Repository navigation
fix(voice): retain the original error when chat fallback is empty - #240
mangeshraut712 wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code Review Roast 🔥Verdict: No Issues Found | Recommendation: Merge Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything. 📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are. Files Reviewed (1 file)
Reviewed by free · Input: 36.5K · Output: 2.9K · Cached: 104.1K |
When the primary voice-chat attempt fails and the fallback response has no usable text, keep the primary failure as the fallback error’s
cause. Successful fallback responses and the existing user-facing error message are unchanged.This source-only fix addresses the
preserve-caught-errorfailure surfaced by #238. It does not change dependency versions or modify the Dependabot branch.Validation on Linux / Node 24: exact unmodified #238 head reproduced the lint failure, and then lint, typecheck, 72 frontend tests and production build passed with the fix. Those same four frontend checks also passed on current main plus this patch. Independent focused verification covered both fallback success and cause preservation. Draft for the repository’s hosted Node 22 checks and ordinary review. Backend jobs and hosted checks were not run locally.
Note
Low Risk
One-line error constructor change in voice fallback failure path; no API or UX behavior changes.
Overview
When standard voice chat fails and the fallback model returns no usable text after cleaning, the thrown
Fallback failederror now includes the original primary failure via{ cause: err }.Successful fallback paths and the user-facing “Unable to connect” message are unchanged. This is a small error-chain fix for logging and lint (
preserve-caught-error).Reviewed by Cursor Bugbot for commit fc02232. Bugbot is set up for automated code reviews on this repo. Configure here.