Skip to content

fix(voice): retain the original error when chat fallback is empty - #240

Open
mangeshraut712 wants to merge 1 commit into
mainfrom
fix/preserve-voice-fallback-error
Open

mangeshraut712 wants to merge 1 commit into
mainfrom
fix/preserve-voice-fallback-error

Conversation

@mangeshraut712

@mangeshraut712 mangeshraut712 commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

When the primary voice-chat attempt fails and the fallback response has no usable text, keep the primary failure as the fallback error’s cause. Successful fallback responses and the existing user-facing error message are unchanged.

This source-only fix addresses the preserve-caught-error failure surfaced by #238. It does not change dependency versions or modify the Dependabot branch.

Validation on Linux / Node 24: exact unmodified #238 head reproduced the lint failure, and then lint, typecheck, 72 frontend tests and production build passed with the fix. Those same four frontend checks also passed on current main plus this patch. Independent focused verification covered both fallback success and cause preservation. Draft for the repository’s hosted Node 22 checks and ordinary review. Backend jobs and hosted checks were not run locally.


Note

Low Risk
One-line error constructor change in voice fallback failure path; no API or UX behavior changes.

Overview
When standard voice chat fails and the fallback model returns no usable text after cleaning, the thrown Fallback failed error now includes the original primary failure via { cause: err }.

Successful fallback paths and the user-facing “Unable to connect” message are unchanged. This is a small error-chain fix for logging and lint (preserve-caught-error).

Reviewed by Cursor Bugbot for commit fc02232. Bugbot is set up for automated code reviews on this repo. Configure here.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mangeshraut712
mangeshraut712 marked this pull request as ready for review November 21, 2026 17:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T17:20:47.290765Z fc02232 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-21T17:21:56.941974Z fc02232 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@kilo-code-bot

kilo-code-bot Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Code Review Roast 🔥

Verdict: No Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything.

📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are.

Files Reviewed (1 file)
  • src/components/features/AdvancedVoiceMode.jsx - 0 issues

Reviewed by free · Input: 36.5K · Output: 2.9K · Cached: 104.1K

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant