Repository navigation
Snapshot Deletions - #38
Open
gabrielbornstein wants to merge 10 commits into
Open
gabrielbornstein wants to merge 10 commits into
gabrielbornstein wants to merge 10 commits into
Conversation
…ite to Checkpoint Volume
…ornste/snapshot-deletions
tonyastolfi
reviewed
Oct 13, 2026
tonyastolfi
reviewed
Oct 22, 2026
| // | ||
| Status KVStore::delete_snapshot(EditOffset checkpoint_edit_offset) noexcept | ||
| { | ||
| // TODO: [Gabe Bornstein 10/12/26] commit_checkpoint does this. Do we need delete_snapshot to do |
Collaborator
There was a problem hiding this comment.
I think we could replace this with BATT_CHECK_OK(this->wait_for_recovery()) -- At the point when its possible for application code to call delete_snapshot, we know recovery is done because KVStore::open has returned.
| { | ||
| std::lock_guard<std::mutex> lock{this->checkpoint_mutex_}; | ||
|
|
||
| if (this->active_checkpoints_.num_active_checkpoints == 0) { |
Collaborator
There was a problem hiding this comment.
Re: your comment in PackedActiveCheckpoints::erase: these checks should move into that function, making this one as simple as 1. lock the mutex, 2. call erase.
| public: | ||
| void SetUp() override | ||
| { | ||
| KVStoreTest::SetUp(); |
| // | ||
| { | ||
| Status status = kv_store->delete_snapshot(checkpoint_offsets.back()); | ||
| EXPECT_FALSE(status.ok()) << "Deleting the newest checkpoint should fail"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.