Repository navigation
fix(vivo): upload the signed vivo APK on its own, with a readable name - #2690
Closed
cuong-tran wants to merge 1 commit into
Closed
cuong-tran wants to merge 1 commit into
cuong-tran wants to merge 1 commit into
Conversation
The release job uploaded vivoAndroidApp/build/outputs/apk/release/*.apk, which zipped the unsigned APK that build_and_sign_apk.sh leaves behind together with the signed one. The nightly zipped its one APK under the name vivoAndroidApp-release-unsigned-signed.apk. Both jobs now copy the single signed APK to SimpMusic-<version>-[nightly-<sha>-]full-vivo-arm64-v8a.apk and upload it with upload-artifact@v7 and archive: false, so it downloads as the APK itself instead of a zip. The step fails unless it finds exactly one signed APK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job uploaded vivoAndroidApp/build/outputs/apk/release/*.apk, which zipped the unsigned APK that build_and_sign_apk.sh leaves behind together with the signed one. The nightly zipped its one APK under the name vivoAndroidApp-release-unsigned-signed.apk.
Both jobs now copy the single signed APK to SimpMusic--[nightly--]full-vivo-arm64-v8a.apk and upload it with upload-artifact@v7 and archive: false, so it downloads as the APK itself instead of a zip. The step fails unless it finds exactly one signed APK.