Skip to content

ci(android): let pull requests from forks build #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuong-tran wants to merge 1 commit into
base: dev
Choose a base branch
from
+10 −2
Open

ci(android): let pull requests from forks build #2710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,10 @@ jobs:
echo "BUILD_TOOL_VERSION=$BUILD_TOOL_VERSION" >> $GITHUB_ENV
echo Last build tool version is: $BUILD_TOOL_VERSION

# A pull request from a fork gets no secrets, so it only checks that the APK builds.
- uses: kevin-david/zipalign-sign-android-release@v2
id: sign_app
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
with:
releaseDirectory: androidApp/build/outputs/apk/release
signingKeyBase64: ${{ secrets.SIGNING_KEY }}
Expand All @@ -83,6 +85,7 @@ jobs:
BUILD_TOOLS_VERSION: ${{ env.BUILD_TOOL_VERSION }}

- name: Upload APK
if: steps.sign_app.outcome == 'success'
uses: actions/upload-artifact@v4
with:
name: app
Expand Down Expand Up @@ -137,8 +140,10 @@ jobs:
echo "BUILD_TOOL_VERSION=$BUILD_TOOL_VERSION" >> $GITHUB_ENV
echo Last build tool version is: $BUILD_TOOL_VERSION

# A pull request from a fork gets no secrets, so it only checks that the APK builds.
- uses: kevin-david/zipalign-sign-android-release@v2
id: sign_app
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
with:
releaseDirectory: vivoAndroidApp/build/outputs/apk/release
signingKeyBase64: ${{ secrets.SIGNING_KEY }}
Expand All @@ -150,6 +155,7 @@ jobs:
BUILD_TOOLS_VERSION: ${{ env.BUILD_TOOL_VERSION }}

- name: Upload APK
if: steps.sign_app.outcome == 'success'
uses: actions/upload-artifact@v4
with:
name: app-vivo
Expand Down
3 changes: 2 additions & 1 deletion androidApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ sentry {
}
authToken.set(token ?: "")
includeProguardMapping.set(true)
autoUploadProguardMapping.set(true)
// Pull requests from forks get no secrets: build without uploading instead of failing on a 401.
autoUploadProguardMapping.set(!token.isNullOrBlank())
} else {
includeProguardMapping.set(false)
autoUploadProguardMapping.set(false)
Expand Down
3 changes: 2 additions & 1 deletion vivoAndroidApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ sentry {
}
authToken.set(token ?: "")
includeProguardMapping.set(true)
autoUploadProguardMapping.set(true)
// Pull requests from forks get no secrets: build without uploading instead of failing on a 401.
autoUploadProguardMapping.set(!token.isNullOrBlank())
} else {
includeProguardMapping.set(false)
autoUploadProguardMapping.set(false)
Expand Down
Loading