Repository navigation
feat(List): a row tapped to push stays selected until the pop deselects it #8082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8a8ac32
5e41033
7ee6305
66d1919
225e202
63c3eb8
8c0dbf1
bfcb164
d5ae22d
475b34e
66edc03
a2ac6f9
d019124
f05cb57
0e62702
d51ab32
7c84cb3
b61f1ff
1e242be
6809bb8
9d39d7d
ab1afb2
4adaf8b
f4c4108
4392e97
dcfcddb
b9a18f5
ab02b27
4874db4
8c8d6f5
3d201a0
f581948
8cd46df
54561a1
1e1b7bd
efdffbe
c833823
89614c7
bd9246d
5d9e4ec
7b26ef2
b61b264
4051fac
370c4d9
15c71e1
2bcd5b2
3c0d8a0
e8b0bb6
2c57208
1e5d0f4
16d3f24
4eac57c
347f0ac
b600a78
772a4b5
7d946d2
ee34b25
355a456
c4412ab
effe685
d5a65fa
66232e6
0d1a829
571f088
4c41132
9320644
7ad0455
156e4b3
f60e87d
6eb2193
86ac77d
9d5c20a
b4234d7
cb907b7
462d82c
8fc7f2e
0543b78
79dc151
1fde85a
a4b10f9
1fe597d
85002df
b33685a
fa62e29
2cb04fe
803e6d6
fa8c8e2
1ffb20e
a9be409
c2bc85e
c97ab3d
c84803b
84ea877
3cb158a
f0819b9
f9f1162
dcfecc9
2267ee5
b84bcfc
648f355
c494681
4750680
6d3cb42
e07c385
1346af4
02ff48f
7847980
c4d1994
374ab86
528dd2d
e05cdd1
b814769
b3f68de
f866874
3190b1a
d1b07a4
51688cd
274ee1b
2f3d6ef
bb79455
23e9ead
93c611d
79aa498
63218c8
0400cb2
c4b964e
be661e2
7f36229
72c25bd
3153b09
5ad1170
49460a6
1a40c3a
f4e8812
835e4e4
38ea7d9
76d99bb
215f031
da5dcb2
47a30b0
7f0f5c4
5712c49
4045092
6762cc5
03058f6
bf5950f
d12ed28
61de06c
c1c46dc
ddf0e3a
f33aea7
357a725
92d6477
6c53298
1ca0138
45a454b
c6f0678
ed4a046
3e3c4e7
a7ffe6e
36abaa1
2931530
b4e0adb
2b264d3
13eceed
212dbb1
ecb9f20
62ecda1
e92759a
93e6d3e
c2fd1bb
66c651f
7d725ad
0519913
4d3bacb
5613501
a149b9c
852d55c
4099d7e
6ccd5b4
40c6be3
87e516b
572825b
4c3df94
c8d86ff
bce5d90
7613c98
f79b8a9
a1e7176
ff365ff
97436b2
c27baac
bac4669
f1c5125
bd50829
f405e7f
702529b
fda011c
8715133
15e8c24
bc90acb
7aba599
9f6748f
a103c43
4012259
2a6b934
9f65026
2ec969c
1ddea08
213e86e
6ef5186
70c70e4
6f4173c
915f9d9
d2c3c78
266fa0a
8839b53
25b468c
182ef2e
793c8db
b9c3b0b
27eeeb8
530adc8
2567163
bec2283
a3e07d8
9adbe2d
cba0ad9
8766c55
1a693f3
e7b3c0a
3bfd7c3
1aade8a
3d85c30
9d0f6f2
11dbebf
d9a1e1a
e6ab0b9
3fb31dd
2121d8f
01b48e5
3e73461
4130bcc
03b2538
7539a46
0b0a99f
96153e7
d9d4468
1fd7580
7e0020c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/build': patch | ||
| --- | ||
|
|
||
| [fix] `astryxStylex` resolves `defineConsts` values read from another file. With the `{stylexOptions}` form (the one Storybook uses), a file that read only constants from a `.stylex.ts` module lost that import once StyleX compiled it, so the constants never reached the CSS: a constant used as a media-query key failed the build ("Invalid empty selector") and one used as a value shipped as a custom property nothing declares. In either form, a constant defined on the other side of the layer split, or in an Astryx package (compiled with the library class-name prefix) and read from an app file (compiled with its own), stayed unresolved. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: a gesture that cancels itself on a finger's move (a long press dragged past its tolerance) keeps that finger claimed until it lifts, so the page never takes the drag over midway; a resting finger is still given back when its gesture is cancelled. Not exported from the package entry point. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: touch-action derivation, the native scroll probe and haptics for the gesture system. Not exported from the package entry point. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: the gesture system's DOM host (claims, click suppression, the browser's takeover, the pointer behind a contact). Not exported from the package entry point. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: UIControl press tracking with control and cell profiles and the gesture hooks, with every press painter writing `data-astryx-press` through one internal writer in `utils/pressFeedback.ts`. Not exported from the package entry point. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: the gesture system's README for component authors, with its browser proof in Chromium and WebKit. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: swipe, pinch, rotation, screen-edge pan and hover gesture recognizers. Not exported from the package entry point. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [feat] In a `List` with `hasDividers`, a touch press hides the dividers on either side of the pressed row, so the pressed row reads as one unbroken highlight; both come back the moment the finger lifts, while the highlight fades. This applies under any finger (a coarse primary pointer); with a mouse the dividers stay drawn. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [fix] A list row's touch press release keeps fading while the page runs script. `ListItem`, `Item` and `TreeList` rows used to stay fully pressed after the finger lifted until the main thread was free, and every frame of the fade repainted the row; the release now runs on the compositor, with the same color, clock and curve as before. Under a finger, while a row is pressed and through its release, the press paints on the row's `::before` and the row is its own stacking context; at rest nothing of it applies, so a row's own `::before` decoration and its children's stacking are as they were. During a press the layer is the row's `::before`, so a caller's decoration there takes the layer's box and paint for that time (a page stylesheet keeps the properties it sets); decoration that should stay through a press belongs on `::after` or a child element. With a mouse or trackpad the row is unchanged: no layer and no new stacking context. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| '@astryxdesign/cli': patch | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No file under There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No file under There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No CLI file changes in this pull request, so this line only adds a List note to the CLI’s changelog. Drop it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No file under There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No file under |
||
| --- | ||
|
|
||
| [chore] Internal: under a finger, a list row tapped to push can stay selected while the pushed screen covers it, then deselect as the screen pops, as a UIKit table row does; with a mouse the press releases at the lift as before. The hold that drives it (`List/selectionHold.ts`) is internal to core, so no public export changes. The deselect runs on the compositor, and a divided list keeps the dividers around the held row hidden. | ||
|
|
||
| @vjeux | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: Reduce Motion for the touch presentations follows design:reduced-motion beyond the animator too. `reducedMotionFade()` gives code beside the animator the animator's own fade (an opacity-only 200 ms cross-fade on a coarse pointer or after a touch release, at once on any other pointer), `animator.reducedMotion()` reports which form a change takes for feedback that plays no fade of its own, and `reducedMotion.stylex.ts` holds the fade's constants for StyleX transitions. The fade's length is not a theme motion role. Not exported from the package entry point. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: the touch presentations' animator drives a pseudo-element such as a dialog's ::backdrop: a static filling animation holds its value after a curve ends and after `set`, a custom property on its host promotes it, and a Reduce Motion dip borrows and hands back the pseudo-element's own opacity. Not exported from the package entry point. | ||
|
|
||
| @vjeux |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: useAnimator, a React wrapper around the touch presentations' animator that never re-renders per frame, and browser proofs on the interaction harness that the animator's motion keeps running through a blocked main thread in Chromium and WebKit. Not exported from the package entry point. | ||
|
|
||
| @vjeux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No file under
packages/clichanges in this pull request now that the CLI doc entry is gone, so this line would publish a CLI patch whose changelog describes a List row. Drop it.