Repository navigation
spec(AST-094): touch presentations feel native by default #8409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0506deb
spec(AST-094): touch presentations feel native by default
cixzhang 6758036
spec(AST-094): touch only; the INV10 amendment moves to its own change
cixzhang 7f3063e
spec(AST-094): drop FR4's public-surface sentence
cixzhang e3acbed
spec(AST-094): primary pointer governs; the row swipe keeps its const…
cixzhang c523ca2
Merge main into the AST-094 revision; FR36 keeps the row swipe out
cixzhang 49dff39
spec(AST-094): Popover's moved touch default; menus follow the primar…
cixzhang 74c12fc
spec(AST-094): a pan outside closes menus only; Popover dismissal unc…
cixzhang 20eceaa
spec(AST-094): the primary pointer is the one rule for menu fingers
cixzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hands the row's slide and spring motion to theme motion roles, but FR4's table has no row-swipe role and this record measures none, so Item's swipe has no named role or sourced default to read once it may no longer play its constants. Please name which FR4 roles the slide and the spring-back play (or add the row's measured roles with sources), or keep the durations as source constants until they are measured.