Repository navigation
Export portable MOV experiments with validated complete media - #141
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new symbolic-link destination refusal remains untranslated and lacks entries in all three translation catalogs, causing an English diagnostic regardless of the selected locale.
1 open issue
What changed in this PR
Adds portable .trz export for audited, indexed constant-rate MOV experiments, extending MoTrack’s existing image-packaging workflow. Broader movie containers remain unsupported; this does not resolve the historical MOV/Open Recent issue.
Changes:
- Copies complete MOV media and validates staged frame counts and timestamps before atomic replacement.
- Extends desktop export while preserving save destinations, dirty state and undo/redo history.
- Adds native, desktop and corpus regression coverage, plus documentation and translation updates. Current-head cross-platform CI and actual-Tracker acceptance remain pending.
| File | Description |
|---|---|
translations/motrack_fr.ts |
Updates French catalog entries for media export. |
translations/motrack_es.ts |
Updates Spanish catalog entries for media export. |
translations/motrack_de.ts |
Updates German catalog entries for media export. |
tools/corpus.py |
Adds MOV package oracles and three round-trip modes. |
tests/tracker_movie_package_test.cpp |
Tests complete-media preservation, refusals and destination protection. |
tests/test_corpus.py |
Tests MOV package XML and byte-validation oracles. |
tests/image_package_workspace_test.cpp |
Covers desktop MOV export, session preservation and cancellation. |
tests/corpus/README.md |
Documents portable MOV acceptance requirements. |
tests/corpus/manifest.json |
Enables MOV package round-trip coverage. |
tests/corpus_probe.cpp |
Adds native MOV package export modes. |
src/tracker_writer.hpp |
Declares the portable MOV writer contract. |
src/tracker_image_package.cpp |
Shares packaging logic and validates staged MOV media. |
src/paired_save.hpp |
Declares destination-locked MOV copy export. |
src/main_window.hpp |
Renames the archive chooser for shared media use. |
src/main_window.cpp |
Enables and dispatches indexed MOV export. |
README.md |
Documents portable image and MOV export workflows. |
docs/upstream-issues.md |
Records merged MOV archive evidence and remaining restrictions. |
docs/native-format.md |
Defines portable MOV packaging guarantees and limits. |
docs/migration-plan.md |
Updates implementation status and scoped acceptance evidence. |
CMakeLists.txt |
Links media validation and registers MOV package tests. |
Review effort: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
Required current-head Tracker load/save, fresh-process reopen, and three-platform validation remain pending, so the available source-only, native, and oracle evidence cannot establish MOV interoperability.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
Copilot stopped reviewing on behalf of
mgradwohl due to an error
November 9, 2026 07:35
Copilot stopped reviewing on behalf of
mgradwohl due to an error
November 9, 2026 07:48
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
3 open issues
requireReadable(...)is used for non-I/O validation (index/frame-time mismatch). When this fails,… · Newverify_media_package_exportno longer checkspackage.testzip()and does not normalize… · New
3 resolved since last review
Review effort: Lite
Copilot stopped reviewing on behalf of
mgradwohl due to an error
November 9, 2026 08:06
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
4 open issues
document.project.clip.sourceFrameCountbeing present and matching… · Newcache_policychanges the emitted report schema for all modes, not just the new… · NewimageArchiveProgress,cancelImageArchiveExport) are now misleading because… · New
3 resolved since last review
Review effort: Lite
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the portable MOV archive export changes.
No open issues 🎉
4 resolved since last review
cache_policychanges the emitted report schema for all modes, not just the new…document.project.clip.sourceFrameCountbeing present and matching…imageArchiveProgress,cancelImageArchiveExport) are now misleading because…
Review effort: Balanced
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
A linked MOV experiment can now be exported as a portable
.trzthrough File → Export portable archive…. The package copies the complete movie without conversion, preserves audited mass/mark/clip-range edits, and keeps the current document's save destinations, dirty state and undo/redo history. Opening the package supports the existing paired Save workflow and optional native companion.The shared image/MOV adapter uses bounded staging, ZIP validation, atomic replacement, cancellation and destination locks. Before replacement, FFmpeg re-indexes the immutable staged movie and requires its complete frame count and timestamps to match the document. Unreadable media and changed movie timing receive distinct translated diagnostics. The independent package oracle checks every bounded member's CRC, hash and XML content and reports corrupt ZIPs consistently.
Validation
Tested and reviewed revision:
d0e1a66cac54aeb8f559c9d5c5835330f34ca7d3.linked-mov/packaged-movie,packaged-movie-clipandpackaged-movie-clip-single. Each starts after native save/reopen and original-project removal; all external movie files are removed before Tracker opens the actual archive. Complete XML/movie-byte checks, Tracker save/fresh-process reopen and native reimport pass. Existing four-mode all-tab MOV archive acceptance also passes.Regression coverage includes full media outside clip bounds, source removal/relocation, native/archive reopen, stale timing/corrupt movies and ZIP CRCs, unsupported inputs, cancellation, destination locks/pending recovery, desktop export, undo/redo and ordinary/paired saving afterward.
Compatibility and review
Other movie containers remain refused under #140. The audited MOV writer retains unchanged timing, calibration and track identity requirements. Broader containers, variable timing, filters, unsupported schemas and full export authoring remain unfinished. This adds scoped coverage related to #65; it does not reproduce or close the historical MOV/Open Recent report. Java remains development-reference tooling only.
docs/code-review.md; all discussions resolved.