Repository navigation
Enhance test coverage for search tools and utilities - #1567
Merged
Dan Hellem (danhellem) merged 2 commits intoAug 31, 2026
Merged
Dan Hellem (danhellem) merged 2 commits into
Dan Hellem (danhellem) merged 2 commits into
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
aaudzei
approved these changes
Aug 31, 2026
Dan Hellem (danhellem)
deleted the
users/danhellem/update-tests-for-full-coverage-1
branch
August 31, 2026 19:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive tests for search tools and utility functions, improving coverage for various input scenarios, error handling, and request payloads. It also makes a minor code change to always provide a version descriptor in
fetchCombinedResults.Test coverage improvements:
DomainsManager.parseDomainsInputtest coverage to handle whitespace-only strings and empty arrays as input.getCliArgsusesprocess.argvby default and to check legacy URL handling ingetOrgFromUrl. [1] [2]Code logic update:
fetchCombinedResultsto always provide aversionDescriptorobject, even whenchangeIdis not present, ensuring consistent API calls.GitHub issue number
N/A
Associated Risks
None
✅ PR Checklist
🧪 How did you test it?
Fixed and re-ran automated tests