Repository navigation
fix: report longitude error in geohash assertion - #2361
Open
Nikolay Zdravkov (unsafePtr) wants to merge 1 commit into
Open
Nikolay Zdravkov (unsafePtr) wants to merge 1 commit into
Nikolay Zdravkov (unsafePtr) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues with the change correcting the longitude assertion’s diagnostic error value.
No open issues 🎉
What changed in this PR
Corrects the longitude round-trip assertion diagnostic in the geohash tests so failures report the longitude error rather than the latitude error.
Changes:
- Uses
lonErrorin the failure message; assertion logic and numeric formatting remain unchanged.
| File | Description |
|---|---|
test/standalone/Garnet.test.collections/GeoHashTests.cs |
Reports the correct error value in the longitude assertion message. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report the longitude error in the longitude round-trip assertion message. It currently prints the latitude error, which gives the wrong diagnostic when the longitude check fails.