Repository navigation
docs(gpu-offload): update provenance documentation - #2203
SHIVANG RAJ (shivang-raj) wants to merge 6 commits into
Conversation
Formatted the provenance table and standardized the spelling of license. Prepared by GPT (OpenAI Codex) at Shivang Raj's request; committed under Shivang Raj's GitHub account.
|
Please review this Katrien De Graeve (@katriendg) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
- Coverage 87.30% 87.17% -0.13%
==========================================
Files 402 389 -13
Lines 52480 51386 -1094
Branches 7309 7162 -147
==========================================
- Hits 45817 44796 -1021
+ Misses 5362 5319 -43
+ Partials 1301 1271 -30
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Jamie Kim (jkim323)
left a comment
There was a problem hiding this comment.
Thank you for picking up #2194, SHIVANG RAJ (@shivang-raj), and for checking this provenance record against what's actually in the tree. You're right that ros2_bridge/ never landed on main, so removing that Apache-2.0 exception makes the file more accurate, and recording the LeRobot 0.6.1 pin is a helpful addition.
Because this file is the licensing record behind the MIT headers on the adapted gpu-offload files, we have a few suggested changes before merge:
- Keep an explicit MIT statement that covers the material adapted from the upstream reference (lines 47-49).
- State the licensing permission directly rather than citing an "original porting record" that readers can't locate (lines 29 and 33-34).
- Remove the paragraph about the missing
ros2_bridge/directory (lines 58-61). - Mention the MIT section change in the PR description, and check or briefly explain the two open checklist items.
Each inline comment includes a suggestion you can apply directly. Please comment if you have questions about any of these, and we're happy to discuss.
|
Jamie Kim (@jkim323) Thanks for the detailed review and suggestions! I've addressed all four inline comments in the latest commit:
I've also updated the PR description to reflect the licensing clarification. Thanks again for the helpful feedback! |
|
Jamie Kim (@jkim323) please review this once free. |
Pull Request
Description
Updates
gpu-offload/PROVENANCE.mdto address the documentation issues raised in #2194.Changes include:
XAVIER-PORTING.md.0.6.1).ros2_bridge/directory.Closes #2194
Type of Change
Component(s) Affected
gpu-offload/- GPU offload documentationdocs/- DocumentationTesting Performed
git diff --checkpassedDocumentation Impact
Bug Fix Checklist
Not applicable — documentation-only change.
Checklist