Skip to content

Decommit memory on cls #20889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Leonard Hecker (lhecker) wants to merge 2 commits into
base: main
Choose a base branch
from
+276 −127
Open

Decommit memory on cls #20889

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e9cd4b
Decommit memory on cls
lhecker Nov 5, 2026
05a7892
Ignore C26494
lhecker Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .github/actions/spelling/expect/expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ acp
actctx
ACTCTXW
ADDALIAS
ADDREF
ADDSTRING
ADDTOOL
adml
Expand Down Expand Up @@ -169,14 +168,11 @@ chshdng
CHT
CInput
CLASSSTRING
CLAUDE
cleartype
CLICKACTIVE
clickdown
CLIENTID
clipbrd
CLIPCHILDREN
CLIPSIBLINGS
closetest
cloudconsole
cloudvault
Expand Down Expand Up @@ -338,7 +334,6 @@ dblclk
Dcd
DCOMMON
DComposition
DDESHARE
DDevice
DEADCHAR
debugtype
Expand Down Expand Up @@ -385,6 +380,8 @@ DECNKM
DECNRCM
DECOM
decommit
decommitted
decommitting
DECPCCM
DECPCTERM
DECPS
Expand Down Expand Up @@ -605,6 +602,7 @@ fte
Ftm
Fullscreens
FUNCTIONCALL
Furia
fuzzmain
fuzzmap
fuzzwrapper
Expand Down Expand Up @@ -1228,7 +1226,6 @@ pcshell
PCSHORT
PCSR
PCSTR
PCWCH
PCWCHAR
PCWSTR
pdbs
Expand Down Expand Up @@ -1346,7 +1343,6 @@ PSobject
psp
PSPCB
psr
PSTR
psz
ptch
ptsz
Expand Down Expand Up @@ -1799,6 +1795,7 @@ uwa
uwp
uwu
uxtheme
VADs
Vanara
vararg
vclib
Expand Down Expand Up @@ -1992,7 +1989,6 @@ yact
YCast
YCENTER
YCount
yizz
YLimit
YPan
YSubstantial
Expand Down
6 changes: 6 additions & 0 deletions src/buffer/out/Row.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,6 +1254,12 @@ void ROW::SetScrollbarData(std::optional<ScrollbarData> data) noexcept
_promptData = data;
}

void ROW::SetScrollbarData(std::nullopt_t) noexcept
{
// Avoid copying the unused payload of an empty optional.
_promptData.reset();
}

void ROW::StartPrompt() noexcept
{
if (!_promptData.has_value())
Expand Down
1 change: 1 addition & 0 deletions src/buffer/out/Row.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ class ROW final

const std::optional<ScrollbarData>& GetScrollbarData() const noexcept;
void SetScrollbarData(std::optional<ScrollbarData> data) noexcept;
void SetScrollbarData(std::nullopt_t) noexcept;
void StartPrompt() noexcept;
void EndOutput(std::optional<unsigned int> error) noexcept;

Expand Down
Loading
Loading