Repository navigation
feat(plugin): serve globally authorized Solid GUI bundles - #2
Closed
mortezaPRK wants to merge 2 commits into
Closed
mortezaPRK wants to merge 2 commits into
mortezaPRK wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fork-only review · layer 2/9 · related upstream work: anomalyco#55246. No upstream submission.
Type of change
What does this PR do?
Admit GUI-only packages explicitly listed in global config. Keep GUI code out of server execution, compile JSX with Solid, and serve code + JSON options through
plugin.gui.How did you verify your code works?
bun run checkpassed with Bun 1.4.4 (34 tasks); Core plugin module tests 11 passed, server bundle test 1 passed, Desktop loader tests 2 passed. Tart + production Electron E2E on the current stack: 1 passed (8.7s) with five example packages (sidebar groups, header badge, facts panel, inspect menu, main-entry log).tart run oc-test --dir="source:$PWD:ro", then in the VMrsyncthe checkout,bun install --frozen-lockfile, buildpackages/desktopwithOPENCODE_CHANNEL=local OPENCODE_VERSION=2.1.4, configure the example packages (from feat(plugin): add a project sidebar example #8, feat(plugin): add a session badge example #10, feat(plugin): add a session panel example #12, feat(plugin): add a session menu example #14, feat(plugin): add a launch-log main entry example #16) in globalplugins, launch Electron withOPENCODE_DESKTOP_PLUGIN_MAIN=1, and drive it over CDP.Rationale: only the server's real Solid and Node bundlers produce loadable plugin code. Result: 1 passed (8.7s); screenshots in feat(plugin): add a project sidebar example #8, feat(plugin): add a session badge example #10, feat(plugin): add a session panel example #12, feat(plugin): add a session menu example #14, feat(plugin): add a launch-log main entry example #16.
Screenshots / recordings
Example screenshots: #8 sidebar, #10 header, #12 panel, #14 menu, #16 main.
Checklist