Skip to content

fix: build jawn and web on Node 24 and publish images to Artifact Registry - #1

Merged
eruizgar91 merged 1 commit into
mainfrom
chore/node-24-images
Oct 22, 2026
Merged

eruizgar91 merged 1 commit into
mainfrom
chore/node-24-images

Conversation

@eruizgar91

Copy link
Copy Markdown
Member

What

Build the self-hosted Helicone images we deploy (jawn, web, migrations) on Node 24 and publish them to our Artifact Registry. Upstream has not published Docker images since August 2025, and its Dockerfiles are still on Node 20, which is end of life and got no fix in the October 21, 2026 Node.js security release. Tracking: nevermined-io/nvm-monorepo#4611.

Base is upstream main as of 2026-10-20, so the images also carry upstream's recent security fixes (Helicone#5816, Helicone#5841, Helicone#5842) that our staging v2025.08.11 images lack.

Changes

  • valhalla/dockerfile (jawn): node:20.19.4-bookworm-slim -> node:24-bookworm-slim.
  • docker/dockerfiles/dockerfile_web (web): node:20-bookworm-slim -> node:24-bookworm-slim, plus two fixes the build needed:
    • copy packages/pricing/package.json: bifrost depends on @helicone-package/pricing, so the frozen install failed without it (an upstream bug, not Node-related);
    • install python3 make g++ in the builder stage only: better-sqlite3 has no prebuilt binary for Node 24 at the locked version and compiles from source. The runtime stage is unchanged.
  • .github/workflows/nevermined-images.yml: builds the three images on every PR (no push), and on main / dispatch pushes sha-<short> tags to europe-west3-docker.pkg.dev/nevermined-eu-dev/nevermined-io/helicone-{jawn,web,migrations} via Workload Identity Federation (binding for this repo added). The AR repo has immutable tags, so no latest.

Verification (local, linux/amd64)

  • jawn: builds; node --version = v24.22.1; yarn serve loads every module and stops only at the Postgres connection (no DB in the test).
  • web: builds; v24.22.1; next start ready, GET / = 200.

After merge

An argocd PR moves helicone-staging (jawn, web, migration-runner) to these images. Upstream's new Supabase migrations run through the migrations image.

🤖 Generated with Claude Code

…istry

Node 20 is end of life and got no fix in the October 2026 Node.js security release. Move jawn and web to node:24-bookworm-slim. dockerfile_web also copies packages/pricing/package.json (bifrost depends on it) and installs python3/make/g++ in the builder stage because better-sqlite3 has no prebuilt binary for Node 24. nevermined-images.yml builds jawn, web and migrations and pushes sha-* tags to Artifact Registry on main via Workload Identity Federation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@eruizgar91
eruizgar91 merged commit 8936ef6 into main Oct 22, 2026
9 checks passed
@eruizgar91
eruizgar91 deleted the chore/node-24-images branch October 22, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant