Repository navigation
fix: build jawn and web on Node 24 and publish images to Artifact Registry - #1
Merged
Merged
Conversation
…istry Node 20 is end of life and got no fix in the October 2026 Node.js security release. Move jawn and web to node:24-bookworm-slim. dockerfile_web also copies packages/pricing/package.json (bifrost depends on it) and installs python3/make/g++ in the builder stage because better-sqlite3 has no prebuilt binary for Node 24. nevermined-images.yml builds jawn, web and migrations and pushes sha-* tags to Artifact Registry on main via Workload Identity Federation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Build the self-hosted Helicone images we deploy (jawn, web, migrations) on Node 24 and publish them to our Artifact Registry. Upstream has not published Docker images since August 2025, and its Dockerfiles are still on Node 20, which is end of life and got no fix in the October 21, 2026 Node.js security release. Tracking: nevermined-io/nvm-monorepo#4611.
Base is upstream
mainas of 2026-10-20, so the images also carry upstream's recent security fixes (Helicone#5816, Helicone#5841, Helicone#5842) that our stagingv2025.08.11images lack.Changes
valhalla/dockerfile(jawn):node:20.19.4-bookworm-slim->node:24-bookworm-slim.docker/dockerfiles/dockerfile_web(web):node:20-bookworm-slim->node:24-bookworm-slim, plus two fixes the build needed:packages/pricing/package.json:bifrostdepends on@helicone-package/pricing, so the frozen install failed without it (an upstream bug, not Node-related);python3 make g++in the builder stage only:better-sqlite3has no prebuilt binary for Node 24 at the locked version and compiles from source. The runtime stage is unchanged..github/workflows/nevermined-images.yml: builds the three images on every PR (no push), and onmain/ dispatch pushessha-<short>tags toeurope-west3-docker.pkg.dev/nevermined-eu-dev/nevermined-io/helicone-{jawn,web,migrations}via Workload Identity Federation (binding for this repo added). The AR repo has immutable tags, so nolatest.Verification (local, linux/amd64)
node --version= v24.22.1;yarn serveloads every module and stops only at the Postgres connection (no DB in the test).next startready,GET /= 200.After merge
An argocd PR moves
helicone-staging(jawn, web, migration-runner) to these images. Upstream's new Supabase migrations run through the migrations image.🤖 Generated with Claude Code