Repository navigation
test: match only /sing/make/social in route mocks, not social-event - #312
Merged
Merged
Conversation
CodeRabbit (local review of #306-#311): a glob '?' is a wildcard before Playwright 1.52, so 'social?*' would also catch the social-event posts. Use one explicit regex. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012RYLVUT9R9DTcUZB1zhh88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only finding from a local CodeRabbit review (
coderabbit review --committed --base-commit c0768f2) of everything shipped 2026-11-05/06 (#306–#311, 50 files). The GitHub bot never reviewed those PRs because each was merged before it finished.?is a wildcard, so**/sing/make/social?*would also match/sing/make/social-eventand skew the sign-in mocks. Today's environments run 1.58 and 1.64, but nothing pins a minimum. Replaced with one regex,SOCIAL_SIGNIN_URL, in both test files.Tests: 48/48 make-it and account-link e2e tests pass on the build host. Test-only change; nothing changes on the box.
@coderabbitai ignore
🤖 Generated with Claude Code
https://claude.ai/code/session_012RYLVUT9R9DTcUZB1zhh88