Repository navigation
fix(make): keep the singer's title and never split it from the audio (v0.149.3) - #315
Merged
Merged
Conversation
…(v0.149.3) Live 2026-11-05: "Cole Phillips - Roll of Dice". Gemini's "Roll of the Dice" was undone with "keep what I typed", then the make wizard's AI judge applied it again without re-searching, so gen job f01c9997 got the wrong title on the right audio. - sing.js: "keep what I typed" + an unedited form starts the wizard trusted (no AI judge, formatting tidy only). - make.js: a confident content correction is only offered when the audio results already match the typed title (tier 1-2). It is applied with a new search only on weak results. - make.js: undo/redo of a content correction searches again for the shown song. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012RYLVUQ68KFYtZF7vEfhAq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live 2026-11-05: a singer typed "Cole Phillips – Roll of Dice", a 2025 song with no karaoke version. gen's Gemini fallback "corrected" it to "Roll of the Dice", and the singer tapped keep what I typed. The make wizard then ran gen's AI judge again. The judge said "Roll of the Dice" once more, and
applyFullVerdictapplied it without a new audio search, because the results for the typed title were good (tier 2: Spotify "Roll of Dice", score 1.0). gen jobf01c9997ended up with the wrong title on the right audio.Changes
sing.jsmakeIsKeptTyped(): after "keep what I typed", if the form still holds what the singer typed, the wizard startstrusted. Only the formatting tidy runs, not the AI judge.make.jsapplyFullVerdict: a confident content (different-song) correction is only offered ("Did you mean…?") when the audio results already match the typed title (tier 1–2). On weak results (tier 3) it is applied with a new audio search, as before. Accepting the offer re-searches (existingacceptSuggestion).make.jstoggleCorrection: undo/redo of a content correction searches again for the song now shown. A formatting tidy is the same song, so it keeps its results.SONG-IDENTIFICATION.mdD14. Version 0.149.3. The test.pychange triggers the restart that busts?v=.Companion PRs: karaoke-decide#207 (live Spotify search) and karaoke-gen#1256 (grounding rule). Those fix the source of the bad correction. This PR makes the wizard safe whatever the judge says.
Testing
tests/e2e/test_sing_make_wizard.py):scripts/kjbox-test-remote): all pass excepttest_routes.py::test_download_queues_item/test_download_failure_tracked, which fail the same way onmainthere (host environment).@coderabbitai ignore
🤖 Generated with Claude Code
https://claude.ai/code/session_012RYLVUQ68KFYtZF7vEfhAq