Skip to content

fix(layer): keep footer within viewport on short pages #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larbish merged 1 commit into from
Oct 20, 2026
Merged

fix(layer): keep footer within viewport on short pages #1471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion layer/app/app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ const { subNavigationMode } = useSubNavigation(navigation)
<NuxtLoadingIndicator color="var(--ui-primary)" />

<div class="flex">
<!-- Column layout so short pages fit header, main and footer in the viewport -->
<div
class="flex-1 min-w-0"
class="flex-1 min-w-0 flex flex-col min-h-svh"
:class="{ 'docus-sub-header': subNavigationMode === 'header' }"
>
<AppHeader v-if="$route.meta.header !== false" />
Expand Down
11 changes: 8 additions & 3 deletions layer/app/error.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,16 @@ provide('navigation', navigation)

<template>
<UApp :locale="nuxtUiLocale">
<AppHeader />
<div class="flex flex-col min-h-svh">
<AppHeader />

<UError :error="localizedError" />
<UError
:error="localizedError"
class="flex-1 min-h-auto"
/>

<LazyAppFooter hydrate-on-visible />
<LazyAppFooter hydrate-on-visible />
</div>

<ClientOnly>
<AppSearch :navigation="navigation" />
Expand Down
2 changes: 1 addition & 1 deletion layer/app/layouts/default.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<UMain>
<UMain class="flex-1 min-h-auto">
<slot />
</UMain>
</template>
2 changes: 1 addition & 1 deletion layer/app/layouts/docs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ watch(() => route.path, (path) => {
</script>

<template>
<UMain>
<UMain class="flex-1 min-h-auto">
<UContainer>
<UPage>
<template #left>
Expand Down
Loading