Skip to content

fix(SelectMenu): reset the search term when selecting the current item #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjamincanac merged 5 commits into from
Nov 13, 2026
Merged

fix(SelectMenu): reset the search term when selecting the current item #7403

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0751ac
fix(SelectMenu): reset the search term when selecting the current item
benjamincanac Nov 13, 2026
1fdadc8
fix(SelectMenu): reset the search on item select, uncontrolled too
benjamincanac Nov 13, 2026
f84cd34
fix(SelectMenu): reset the search term once per selection
benjamincanac Nov 13, 2026
baebac7
test(SelectMenu): type the parent in the search term test
benjamincanac Nov 13, 2026
f8d6369
fix(SelectMenu): reset the search term when clearing
benjamincanac Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/runtime/components/SelectMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,16 +512,19 @@ function onCreate(e: Event) {
}

function onSelect(e: Event, item: SelectMenuItem) {
if (!isSelectItem(item)) {
return
}
if (isSelectItem(item)) {
if (item.disabled) {
e.preventDefault()
return
}

if (item.disabled) {
e.preventDefault()
return
item.onSelect?.(e)
}

item.onSelect?.(e)
// Selecting the current item updates nothing, so the search is reset here too.
if (!e.defaultPrevented && props.resetSearchTermOnSelect) {
searchTerm.value = ''
}
}

function isSelectItem(item: SelectMenuItem): item is Exclude<SelectMenuItem, SelectMenuValue> {
Expand Down
14 changes: 14 additions & 0 deletions test/components/SelectMenu.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,20 @@ describe('SelectMenu', () => {
input.vm.$emit('update:open', false)
expect(wrapper.emitted()).toMatchObject({ blur: [[{ type: 'blur' }]] })
})

test.each([
['controlled', { modelValue: 'Option 1' }],
['uncontrolled', { defaultValue: 'Option 1' }]
])('resets the search term when selecting the current item %s', async (_, model) => {
const wrapper = mount(SelectMenu, { props: { items: ['Option 1', 'Option 2'], ...model, searchTerm: 'Option', resetSearchTermOnBlur: false, defaultOpen: true, portal: false }, attachTo: document.body })
await flushPromises()
await wrapper.find('[role="option"][data-state="checked"]').trigger('click')

expect(wrapper.emitted('update:searchTerm')).toEqual([['']])
expect(wrapper.emitted('change')).toBeUndefined()

wrapper.unmount()
})
})

describe('clear', () => {
Expand Down
Loading