Repository navigation
Show benchmark run history in the instance tab - #78
Merged
Merged
Conversation
Add a History section listing the instance's 20 most recent runs with tool, status, duration, and metrics or failure reason. It reloads when a run is started and when a run started in the tab finishes, but not when a past run is opened. View opens a run as a result card. The section notes when the service keeps history only in memory, using the storage reported by /api/status. History entries reuse the existing run response validation and reject the whole page on any malformed entry. Status labels and metric value formatting move to shared modules used by result cards and history. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Sergey Pronin <sp@solanica.io>
amh1k
approved these changes
Nov 6, 2026
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #46. UI for persistent run history. Stacked on #77 (needs
GET /api/runsanddatabaseType); review/merge #77 first — this PR's base retargets tomainwhen #77 merges.What changed
BenchmarkRunHistory): the 20 most recent runs, newest first — started time, tool, status chip, duration, metrics (one per line) or the failure reason. View opens a run as the existing result card; runs already shown are marked Shown. Loading, empty, and error-with-retry states; earlier rows stay visible while reloading./api/statusreports in-memory storage, the section explains history is lost on restart and expires after an hour.getBenchmarkServiceStatusnow returns drivers pluspersistentHistory;getEnabledBenchmarkDriversis unchanged for existing callers.benchmarkHistoryApi): reuses the existing strict run validation (parseBenchmarkRun, now exported and able to validate entries without an expected ID) and rejects the whole page on any malformed entry.databaseTypeis parsed when present.Tests
New
benchmarkHistoryApi.test.tsandbenchmarkRunHistory.test.tsx(table content, storage notice, view/shown, reload + failure recovery, abort, and tab-level refresh triggers — verified to fail if refresh-on-finish is removed or applied to opened runs). Existing workflow/registration tests stub the new history request. All frontend suites and the build pass; checked visually in a harness with mocked API data at narrow and 1280px widths.