Repository navigation
[deps] Added support for Django 6.0/6.1, dropped Python 3.10 (EOL) - #823
Conversation
- Added Django 6.0 and 6.1 to the CI matrix for Python 3.12 and 3.13. - Dropped Django 5.1 from the CI matrix since it reached end of life. - Dropped Python 3.10 from the CI matrix and the PyPI build since it reached end of life. - Raised python_requires to 3.11 and updated the minimum Python version in the docs. - Added action_location to get_actions() in the admin, which Django 6.1 passes and warns about when missing. - Removed code needed only for Django < 5.0 from migrations. - Updated admin tests to check the error list id instead of the errors class, since Django 6.1 changed where it is rendered. - Removed an outdated Python version check from the tests and the Python 2 coding declaration from runtests.py. Closes #822
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Linked Issues check |  |
The PR satisfies the directly reviewable #822 objectives. .github/workflows/ci.yml removes Python 3.10 and Django 5.1, adds Django 6.0 and 6.1, and excludes Python 3.11 from those Django versions. `… |
Reviewable evidence is required for the Django 6.0 and 6.1 compatibility of the external openwisp-users and openwisp-notifications dependencies referenced by setup.py. |
-
Check name Status Explanation Title check The title uses the required "[deps]" prefix and describes the main changes: adding Django 6.0/6.1 support and dropping Python 3.10. It matches the CI matrix, python_requires, and PyPI changes in the c… Description check The description follows the template. All four checklist items are checked, and it references issue #822with "Closes#822." It lists the changes in the Description of Changes section, with the CI mat…Out of Scope Changes check The complete diff stays within #822. The CI and package metadata changes remove obsolete Python and Django versions. The admin changes, migration cleanup, test updates, and documentation update suppor…Ui Changes, Regression Test, Docs PASS. The PR does not introduce a new end-user UI; the admin changes preserve existing actions while adding Django compatibility. Admin tests cover validation rendering and action behavior, and the JW… Full details: Title check
-
Explanation
The title uses the required "[deps]" prefix and describes the main changes: adding Django 6.0/6.1 support and dropping Python 3.10. It matches the CI matrix, python_requires, and PyPI changes in the changeset. It does not mention the other changes, such as the admin get_actions update, migration cleanup, and test updates. Those are secondary to the title's main point. The title is also in sentence case and within a reasonable length.
Full details: Description check
-
Explanation
The description follows the template. All four checklist items are checked, and it references issue
#822with "Closes#822." It lists the changes in the Description of Changes section, with the CI matrix, Python 3.10 removal, admin get_actions update, migration cleanup, and test updates. It also lists dependent PRs. The Screenshot section is omitted, which is acceptable because screenshots do not apply to this change. The description does not name specific tests or commands for the manual testing claim, which is a minor gap.
Full details: Out of Scope Changes check
-
Explanation
The complete diff stays within
#822. The CI and package metadata changes remove obsolete Python and Django versions. The admin changes, migration cleanup, test updates, and documentation update support the version transition. No unrelated change is demonstrated.
Full details: Ui Changes, Regression Test, Docs
-
Explanation
PASS. The PR does not introduce a new end-user UI; the admin changes preserve existing actions while adding Django compatibility. Admin tests cover validation rendering and action behavior, and the JWT registration test now runs across supported Python versions. The developer installation documentation updates the minimum Python version to 3.11, and
setup.pymatches it. Screenshots are therefore not required.
-
Full details: Linked Issues check
-
Explanation
The PR satisfies the directly reviewable
#822objectives..github/workflows/ci.ymlremoves Python 3.10 and Django 5.1, adds Django 6.0 and 6.1, and excludes Python 3.11 from those Django versions.setup.pysetspython_requiresto>=3.11. The documentation, compatibility code, admin code, migrations, and tests are updated for the stated version changes. However,#822also requires the other project dependencies to be updated for these versions.setup.pystill references externalopenwisp-usersandopenwisp-notificationsbranches, and this repository does not establish the compatibility of their external code.Resolution
Reviewable evidence is required for the Django 6.0 and 6.1 compatibility of the external
openwisp-usersandopenwisp-notificationsdependencies referenced bysetup.py.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Fix admin add user empty email test failureHello @dee077,
|
Fix sample users admin test assertionsHello @dee077
|
|
Coverage is 98.217% — issues/822-django-6-support into master. No base build found for |
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
Verified the Django 6 CI rerun is green and the compatibility update is ready to merge.
Checklist
Reference to Existing Issue
Closes #822.
Description of Changes
python_requiresto 3.11 and updated the minimum Python version in the developer installation docs.action_locationtoget_actions()in the admin, which Django 6.1 passes and warns about when missing.django.VERSION < (5, 0)branches from migrations, since Django 5.2 is now the minimum.errorsclass, since Django 6.1 changed where it is rendered.runtests.py.Depends on openwisp/openwisp-users#595, openwisp/openwisp-notifications#526 and openwisp/django-loci#257.
Related to openwisp/openwisp-utils#788.