Repository navigation
[GR-80723] Fix publishOldBytecodes emission. - #14790
Merged
graalvmbot merged 4 commits intoOct 28, 2026
Merged
Conversation
Do not emit publishOldBytecodes() from updateBytecode unless instruction tracing is enabled. That method is only generated when tracing (or other bytecode-updatable features) is on, so a tracing-disabled root with no instrumentations failed to compile. Fixes #14682
Gate the generated updateBytecode call on isBytecodeUpdatable() rather than enableInstructionTracing. Tracing-disabled roots with @instrumentation still declare publishOldBytecodes and must invoke it before invalidation.
Rename InstructionTracingDisabledGenerationTest to NotUpdatableBytecodeTest and describe the failure in terms of bytecode updatability. Drop the tests that inspect generated methods; compiling the tracing-disabled root is the regression check.
oracle-contributor-agreement
Bot
added
the
OCA Verified
graalvmbot
deleted the
mdsouza/GR-80723-fix-publishOldBytecodes-emission
branch
October 28, 2026 06:10
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub contribution: #14712