Repository navigation
chore(deps): upgrade emnapi beta.3 and napi cli - #903
Merged
Merged
Conversation
Brooooooklyn
marked this pull request as ready for review
November 3, 2026 03:23
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Brooooooklyn
force-pushed
the
codex/oxc-node-emnapi-beta2
branch
from
November 7, 2026 04:42
d16deff to
2206b1a
Compare
Brooooooklyn
changed the title
Brooooooklyn
added a commit
that referenced
this pull request
Nov 7, 2026
<!-- claude-projects-attribution: {"github_login":"Brooooooklyn"} -->
_Requested by **Brooklyn** · [project
thread](https://claude.ai/code/project/chan_018s9RxRdtH424j2EhXdzV3N?thread=cmsg_018s9RxRdtH424j2EhXdzV3NQxbeR8Pt7qaqSQwoq9rEFo)_
<!-- routine:prune-tests:subset-file-url-tests -->
Before: four one-line file URL tests from #760
(`windows_drive_url_parses`, `windows_drive_path_generates`,
`windows_unc_url_parses_to_unc_path`,
`non_windows_behavior_is_unchanged`) each checked a strict subset of
what another test in the same module checks. No regression fails one of
them without also failing a stronger test.
After: those four tests are gone. Only `#[cfg(test)]` modules in
`src/lib.rs` and `src/windows_file_url.rs` change.
How: each removal was defended by mutating the product code with the
most realistic regression it could catch, running `cargo test
--all-features --lib`, and reverting.
Note: the CI job "Test WASI target" (step "Test bindings") already fails
on `main`, since `ffa98c1` (#901, 2026-11-01). It will fail here too;
this PR does not touch it.
### Totals
- Files touched: 2, test modules only.
- Cases deleted: **4 of 698** (Rust lib 57, Vitest 599, integrate-module
20, integrate-module-bundler 22). After: 694.
- Cases folded: 0.
- Net lines: **−25** (+0 / −25).
- Runtime saved: under 1 ms (each removed case reports `<0.000s`).
### Removals
1. **`windows_drive_url_parses`** (`file:///C:/a/b.ts` → `C:/a/b.ts`).
Keeping the leading `/` in the drive form also fails
`windows_scheme_is_case_insensitive`,
`windows_query_and_fragment_are_not_part_of_the_path`,
`windows_dot_segments_are_normalized` and
`windows_drive_path_is_percent_encoded`.
2. **`windows_drive_path_generates`** (`C:\a\b.ts` →
`file:///C:/a/b.ts`). Not converting backslashes also fails
`windows_drive_path_is_percent_encoded` and
`windows_verbatim_prefix_is_ignored`; converting only the first one also
fails `windows_drive_path_is_percent_encoded`, whose `c:\a:b\x.ts` row
covers the same path.
3. **`windows_unc_url_parses_to_unc_path`** (a three-segment UNC URL).
Converting only the first separator, the one thing its depth adds, also
fails `windows_unc_url_decodes_escapes`, `windows_mapping_interactions`
and `windows_dot_segments_are_normalized`.
4. **`non_windows_behavior_is_unchanged`** (POSIX `file_url_to_path` for
a plain and a `%20` path). It was added with the fix for #744, Windows
URL rules leaking into POSIX paths. That bug's regression (POSIX
`file_url_to_path` calling `windows_file_url::url_to_path`) also fails
`posix_file_url_round_trips`,
`watch_report_urls_are_encoded_and_absolute_only` and
`diagnostics_render_location_and_code_frame`. Dropping `'0'` from
`hex_digit`, skipping decoding, and breaking the no-`%` fast path each
also fail other tests (5, 3 and `posix_file_url_round_trips`).
### Kept after defense
- `windows_escaped_unc_path_round_trips`: its decode-back half is the
only UNC-form check of `%25`.
### Case counts
| suite | before | after | delta |
|---|---|---|---|
| `src/windows_file_url.rs` tests | 32 | 29 | −3 |
| `src/lib.rs` tests | 25 | 24 | −1 |
| integrate-vitest, integrate-module, integrate-module-bundler | 641 |
641 | 0 |
0 failures before and after.
### What ran and what did not
- At `ffa98c1`: all three JS suites against a debug addon, and `cargo
test --all-features` with `--report-time`.
- On this branch: `cargo test --all-features --lib` (53 passed), `cargo
fmt --check`, `cargo clippy --all-targets --all-features -- -D warnings`
and `git diff --check`, all clean.
- Not run: the 3 `loader_context` tests under `--no-default-features`,
Windows, the WASI build and the bench. The JS suites were not re-run
after the change, which touches only `#[cfg(test)]` code.
Open pull requests: neither open PR (#903, #894) touches a test file.
Ages: all four tests were added on 2026-09-14 in #760 and are unchanged
since. None is in a permission or security suite.
To revert: `git revert 53ef6d7`.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01PxVsmvB9xfZKfVnUonY8kf)_
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emnapiand@emnapi/runtimeto2.0.0-beta.3,@napi-rs/clito3.10.12, and direct@napi-rs/wasm-runtimeranges to^1.2.7(supports beta.3 peers).@emnapi/coredependency. Preserve the default pnpm linker and existing CI tests.main(05a51d2) and resolve the lockfile using pnpm 12.9.1.Validation
vp checkpassed formatting, lint, and type checks.git diff --checkpassed.