Repository navigation
fix: add interaction references to the interaction, not the pact - #427
Merged
Merged
Conversation
reference(group, name, value) passed the pact handle to pactffi_add_interaction_reference, which takes an interaction handle. The FFI returned false, which wasn't checked, so no reference reached the pact file. Pass each builder's interaction handle, raise if the FFI still rejects it, and check the written pact file in the message builder spec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reference(group, name, value) passed the pact handle to pactffi_add_interaction_reference, which takes an interaction handle. The FFI returned false, which wasn't checked, so no reference reached the pact file. Pass each builder's interaction handle, raise if the FFI still rejects it, and check the written pact file in the message builder spec.