Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensureDir()discards a failedMKDresponse before tryingCWD. When creation is denied and the directory is missing, callers therefore receive a file-not-found error instead of the server's access-denied reason.Keep the creation rejection if entering that directory also receives an FTP error. Existing directories can still be entered after an unsuccessful
MKD, and successful creation and transport failures retain their existing errors.Fixes #218.
Validation:
npm testpasses on Node 22.23.2 and 24.22.2 (including lint, TypeScript compilation, and all unit tests). Five real local TCP mock-server cases cover the regression, existing and newly created directories, CWD rejection, and connection loss. The exact tests fail once on unmodified master, with four preservation controls passing. Docker integration tests and a Microsoft FTP server were not run locally.