Skip to content

[9.7]PXC-5203: Cluster disruption or deadlock with LOCK TABLES/INSTANCE FOR BACKUP misuse - #2367

Merged
jaideepkarande merged 3 commits into
percona:9.7from
jaideepkarande:PXC-5203-9.7
Oct 14, 2026
Merged

jaideepkarande merged 3 commits into
percona:9.7from
jaideepkarande:PXC-5203-9.7

Conversation

@jaideepkarande

@jaideepkarande jaideepkarande commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Cluster disruption or deadlock with LOCK TABLES/INSTANCE FOR BACKUP misuse

https://perconadev.atlassian.net/browse/PXC-5203

Propagation of the 8.4 fix (#2318) to the 9.7 line.

Problem

A session that ran its own DDL/DML while holding LOCK TABLES FOR BACKUP was
replicated via TOI before the local backup-lock check rejected it, so peers
applied the DDL while the originator failed it locally — causing a Galera
"inconsistency detected" vote and node eviction.

Resolution

The same issue was already fixed for LOCK INSTANCE FOR BACKUP; this extends that
condition to LOCK TABLES FOR BACKUP.

Testing

Jenkins: https://pxc.cd.percona.com/job/pxc-8.x-pipeline-parallel-mtr-AI/67/

Compatibility & upgrade impact

Dimension Impact Notes
In-place upgrade (on-disk / DD / redo-undo / system tables) No No format change; sql/wsrep_mysqld.cc logic only.
Downgrade No Nothing persisted differs.
Rolling / mixed-version cluster Yes — behavioural A statement that previously replicated is now rejected locally. An un-patched node in a mixed cluster still exhibits the old behaviour, so the inconsistency vote remains possible until all nodes carry the fix.
Replication (binlog format, GTID, cross-version) No No binlog or GTID change; the statement is rejected before TOI replication.
Client-server wire protocol No No protocol change.
System variables / config / defaults No No new or changed sysvar.
Cross-version behaviour Consistent Same change applies cleanly on 8.4, 9.7 and trunk.

(8.4)PXC-5229: WSREP applier threads should never have tx_read_only=true
@jaideepkarande
jaideepkarande marked this pull request as ready for review September 14, 2026 19:08
@jaideepkarande

jaideepkarande commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Jenkins results — 9.7

AI job build 6 · Debug · ubuntu:noble · commit f77c7395ce8
PXB: 9.7.1-rc1 → pxb-9.7, 8.4.0-6 → pxb-8.4, 9.1.0 → pxb-9.1
Result: UNSTABLE — 11034 passed, 6 failed. All eight test stages completed.

This change's test passed

test enc_off enc_on
galera.pxc_backup_lock_toi_reject pass (548ms) pass (548ms)

Failures — none related to this change

test assessment
galera_fk_selfreferential (enc_off, enc_on) pre-existing — also fails on the clean 9.7 baseline (build 900) and on unrelated branches (builds 4, 9)
innodb_undo.purge_on_replica unrelated InnoDB undo/purge test; also failed on build 9

shutdown_report entries are MTR's end-of-worker report, raised whenever anything
else in that worker failed; they are not real tests.

…R BACKUP misuse

https://perconadev.atlassian.net/browse/PXC-5203

A session that ran its own DDL/DML while holding LOCK TABLES FOR BACKUP
was replicated via TOI before the local backup-lock check rejected it,
so peers applied the DDL while the originator failed it locally -- causing
a Galera "inconsistency detected" vote and node eviction.

Resolution:
Similar issue was already fixed for "LOCK INSTANCE FOR BACKUP" extended the
condition for "LOCK TABLES FOR BACKUP"
@jaideepkarande

Copy link
Copy Markdown
Contributor Author

Ubuntu azure error is different:

-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:535 (PROJECT):
  The CMAKE_C_COMPILER:

    gcc-16

  is not a full path and was not found in the PATH.

  Tell CMake where to find the compiler by setting either the environment
  variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
  the compiler, or to the compiler name if it is in the PATH.


CMake Error at CMakeLists.txt:535 (PROJECT):
  The CMAKE_CXX_COMPILER:

    g++-16

  is not a full path and was not found in the PATH.

  Tell CMake where to find the compiler by setting either the environment
  variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
  to the compiler, or to the compiler name if it is in the PATH.


-- Configuring incomplete, errors occurred!

@jaideepkarande
jaideepkarande merged commit 1cc91ba into percona:9.7 Oct 14, 2026
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants