Skip to content

PS-11950 [8.4] Release 8.4.11-12 - #2412

Merged
adivinho merged 3 commits into
8.4from
release-8.4.11-12
Nov 16, 2026
Merged

adivinho merged 3 commits into
8.4from
release-8.4.11-12

Conversation

@adivinho

Copy link
Copy Markdown
Contributor

No description provided.

https://perconadev.atlassian.net/browse/PS-11950

skip_compressed_columns() looked for " /*!50633 COLUMN_FORMAT
COMPRESSED" anywhere in SHOW CREATE TABLE output, also inside quoted
strings and identifiers, for example in a column COMMENT. It then
removed text that was not a column format extension, so the table
definition in the dump differed from the original one, and incomplete
extension text could abort the dump.

Add find_unquoted(), which skips quoted strings and identifiers, and use
it to find the extension, its suffix and the dictionary keyword. Stop
looking for extensions when the suffix is missing, read a dictionary
name only when the keyword comes before the suffix, and fail with
EX_CONSCHECK when the name is longer than allowed.

Add percona_innodb.xtradb_compressed_columns_mysqldump_comment, and
percona_innodb.xtradb_compressed_columns_mysqldump_malformed, which uses
Debug-only DBUG_EXECUTE_IF hooks to return malformed extensions from
SHOW CREATE TABLE. Fix the spelling of "compression" in a message the
test prints.
https://perconadev.atlassian.net/browse/PS-11950

mysqldump --enable-compressed-columns-with-dictionaries did not dump and
restore some compression dictionaries correctly:
- Names with quote characters, spaces, keywords, numbers or non-ASCII
  characters were not found or were restored with a different name,
  depending on --skip-quote-names and --default-character-set.
- Different UTF-8 names that compare equal in latin1_swedish_ci were
  dumped only once.
- Non-ASCII dictionary data was restored as "?".

Fix unquote_name() for doubled quotes and --skip-quote-names, look the
dictionary up with a _utf8mb4 hex literal, and compare names with
utf8mb4_general_ci, as the server does. Write DROP and CREATE
COMPRESSION_DICTIONARY with character_set_client=utf8mb4, as CREATE
TABLE is, with the name quoted as SHOW CREATE TABLE quotes it, and with
the data set from a hex user variable.

Add percona_innodb.xtradb_compressed_columns_mysqldump_dictionary_names,
which dumps and restores dictionaries with such names and data, also
with --skip-quote-names, several --default-character-set values and
--compatible=ansi.
https://perconadev.atlassian.net/browse/PS-11950

Raised MYSQL_VERSION_EXTRA to 12 in MYSQL_VERSION file.
Raised PERCONA_INNODB_VERSION to 12 in univ.i file.

@jaideepkarande jaideepkarande left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adivinho
adivinho merged commit 81e2fd6 into 8.4 Nov 16, 2026
7 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants