Repository navigation
fix(windows): keep sandboxed iframes in-process so the markdown viewer loads - #751
Merged
Merged
Conversation
…r loads WebView2 moves iframes sandboxed without allow-same-origin out of process when IsolateSandboxedIframes is on. wry 0.24 registers the phtauri filter without request source kinds, so the markdown viewer's scripts and styles bypass the protocol handler and the viewer never loads. Microsoft turns the feature off by server config today, but it is on for fresh profiles and can be re-enabled remotely at any time. Disable it for every window through WEBVIEW2_ADDITIONAL_BROWSER_ARGUMENTS, appended to wry's defaults. Windows only; other platforms are unchanged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebView2 moves iframes sandboxed without allow-same-origin out of process when IsolateSandboxedIframes is on. wry 0.24 registers the phtauri filter without request source kinds, so the markdown viewer's scripts and styles bypass the protocol handler and the viewer never loads. Microsoft turns the feature off by server config today, but it is on for fresh profiles and can be re-enabled remotely at any time.
Disable it for every window through WEBVIEW2_ADDITIONAL_BROWSER_ARGUMENTS, appended to wry's defaults. Windows only; other platforms are unchanged.