Skip to content

Fix volume adjustment behavior with mouse wheel and touch scroll - #1592

Open
mmstick wants to merge 4 commits into
masterfrom
mouse
Open

mmstick wants to merge 4 commits into
masterfrom
mouse

Conversation

@mmstick

@mmstick mmstick commented Oct 13, 2026

Copy link
Copy Markdown
Member

Fixes the volume adjustment behavior when using a mouse wheel or touchpad

Closes #1215
Closes #1512
Closes #1529


  • I have not included any LLM (also known as AI) generated content in this PR, including code, comments, and descriptions.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.
  • I have read and followed all of the above requirements. For more information, see our contributor guide.

@mmstick
mmstick requested review from a team October 13, 2026 21:39
jackpot51
jackpot51 previously approved these changes Oct 13, 2026
leviport
leviport previously approved these changes Oct 13, 2026

@leviport leviport left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scroll responsiveness feel pretty sluggish. It feels like it only responds to 2 scroll events per second. The level changes at the same rate whether I'm scrolling very slowly or very quickly. I'm sure it would be frustrating to use if it was too responsive, but it feels like scrolling faster should move the slider faster than it currently does.

Regardless, this definitely fixes the muting bug, and a slow feeling adjustment is better than the level switching to 0 with every change.

@mmstick

mmstick commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

I can adjust the delay before we merge it.

@leviport

Copy link
Copy Markdown
Member

From my gut feeling, it feels like it should be somewhere between 50% to 100% faster. I'd probably like it on the faster side, but that might not be worth the risk of inadvertently turning it up higher than intended and causing discomfort to a headphones user.

@mmstick

mmstick commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

Reduced the delay. 128ms is too much for a touchpad but 192ms is still manageable.

@leviport leviport left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That feels a lot better!

@mmstick
mmstick requested a review from jackpot51 October 13, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants