Repository navigation
Conversation
surekap
marked this pull request as ready for review
August 6, 2026 05:38
Contributor
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*wildcard support while escaping all other regular-expression metacharactersProblem
When a database or table has a schema,
Table::getName()returns a qualified name such asgrapevine.t_audit_log. Migration exclusions such as:{ "exclude_tables": ["t_*", "oauth_*", "m_*"] }are therefore ignored, because
t_*is only compared withgrapevine.t_audit_log. A migration diff can then include excluded tables and generate destructive statements for them.The old implementation also interpolated exclusion entries directly into a regular expression. Characters such as
.were treated as regex operators even though the documented behavior is a table-name pattern with*wildcards.Fix
DatabaseComparatornow checks each exclusion against:Table::getName()for explicitly qualified patterns such asgrapevine.t_*Table::getCommonName()for portable patterns such ast_*Patterns are escaped with
preg_quote()before the escaped*is converted to the supported wildcard.Verification
vendor/bin/phpunit tests/Propel/Tests/Generator/Model/Diff/DatabaseTableComparatorTest.phpvendor/bin/phpcs src/Propel/Generator/Model/Diff/DatabaseComparator.php tests/Propel/Tests/Generator/Model/Diff/DatabaseTableComparatorTest.phpgit diff --checkAll pass locally.