Repository navigation
Conversation
surekap
marked this pull request as ready for review
August 6, 2026 05:38
Contributor
|
Nice! Added to Perpl and released as patch, along with your other two PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Table::getCommonName()consistently when creating and resolving generated referrer columnsProblem
For schema-qualified tables,
Table::getName()returns a value such as:Versionable uses that value as a column-name prefix in three places. It consequently attempts to create and resolve columns named:
The schema is table-location metadata and must not become part of a column identifier. This can produce invalid generated SQL and inconsistent behavior between schemas with and without explicit qualification.
Fix
Use
Table::getCommonName()in:addForeignKeyVersionColumns()getReferrerIdsColumn()getReferrerVersionsColumn()The generated names remain
responsibility_matrix_item_idsandresponsibility_matrix_item_versions, independent of the table schema.Verification
masterbefore the production change.vendor/bin/phpunit tests/Propel/Tests/Generator/Behavior/Versionable/VersionableBehaviorTest.phppasses: 16 tests, 23 assertions.vendor/bin/phpcs src/Propel/Generator/Behavior/Versionable/VersionableBehavior.phppasses.git diff --checkpasses.The complete legacy test file has existing PHPCS findings unrelated to this change; the newly added method introduces no new finding.
Scope
This PR intentionally does not rename Versionable-generated foreign keys or indexes. Changing those names would create migration churn for existing applications and should be evaluated separately.
The related schema-qualified Archivable lookup fix is already isolated in #2070.