fix(select): preserve trigger callback types by kotAPI · Pull Request #2261 · rad-ui/ui

kotAPI · 2026-10-18T06:36:56Z

Fix inferred renderValue callback types for Select and Combobox triggers, and document the Select trigger display.

Adds a published-declaration consumer type check and a patch changeset. Addresses #2248; the issue can close when this fix is released.

Checks: Select and Combobox tests, type checks, package build, API surface, and docs checks.

changeset-bot · 2026-10-18T06:37:00Z

🦋 Changeset detected

Latest commit: 0b6b925

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@radui/ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-10-18T06:37:28Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: a71dfb34-1dd6-4535-8ac3-f81e231fb33b

📥 Commits

Reviewing files that changed from the base of the PR and between 3be0f27 and 0b6b925.

📒 Files selected for processing: 12

.changeset/calm-triggers-render.md
.github/workflows/test.yml
docs/app/docs/components/select/content.mdx
docs/app/docs/components/select/docs/codeUsage.js
docs/app/docs/components/select/docs/component_api/item.tsx
docs/app/docs/components/select/docs/component_api/trigger.tsx
docs/app/docs/components/select/docs/render-value.tsx
package.json
scripts/type-tests/select-trigger.tsx
scripts/type-tests/tsconfig.json
src/components/ui/Combobox/fragments/ComboboxTrigger.tsx
src/components/ui/Select/fragments/SelectTrigger.tsx

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 1c1811fb-2390-493e-b305-a74d516ecfd9

📥 Commits

Reviewing files that changed from the base of the PR and between ef4315e and 3be0f27.

📒 Files selected for processing: 5

docs/app/docs/components/select/content.mdx
docs/app/docs/components/select/docs/codeUsage.js
docs/app/docs/components/select/docs/component_api/item.tsx
docs/app/docs/components/select/docs/component_api/trigger.tsx
docs/app/docs/components/select/docs/render-value.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Select documentation now describes trigger value display, documents the Trigger API, and includes an example that renders a custom value.

Changes: Select trigger value documentation

Layer / File(s)	Summary
Document trigger values and API `docs/app/docs/components/select/content.mdx`, `docs/app/docs/components/select/docs/codeUsage.js`, `docs/app/docs/components/select/docs/component_api/item.tsx`, `docs/app/docs/components/select/docs/component_api/trigger.tsx`, `docs/app/docs/components/select/docs/render-value.tsx`	The docs describe selected-label and fallback behavior, add `Trigger` API entries for `children` and `renderValue`, and show an example that displays `"whip-l"` for `"auto"` and otherwise displays the selected value. The API reference now includes `trigger`, and the `Item` label description covers selected display, search, and typeahead.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other · Severity of issue fixed: Medium

Suggested reviewers: goldgroove06

Merge Risk: ⚪ Minimal · up to 3be0f

The docs add a custom-trigger example that is included in the type check and supported by the resolved package, so no actionable merge risk remains.

Pre-merge checks: 2 · 3

Failed checks: 3 warnings

Check name	Explanation	Resolution
Linked Issues check	Issue [`#2248`] requires both documentation and a published `Select.Trigger` type that accepts `renderValue(value, label)`. The PR adds the custom-value section, example, default selected-label explanat…	Add `renderValue` to the published `Select.Trigger` props. Resolve the `ComboboxPrimitive` type export or import path used by the published declarations if it prevents that prop from being emitted. Add or update an automated type check for …
Docstring Coverage	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	The title claims that the change preserves trigger callback types, but the pull request primarily adds Select documentation, a `renderValue` example, and API reference details for custom trigger value…	Rename the pull request to describe the documentation change, such as `docs(select): explain custom trigger values`.

Passed checks: 2 passed

Check name	Status	Explanation
Out of Scope Changes check		The changed files support issue [`#2248`]. They document placeholder and selected-label behavior, add the `renderValue` example and API row, and document the `label` fallback used by the selected displa…
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.

Full details: Out of Scope Changes check

Explanation

The changed files support issue [#2248]. They document placeholder and selected-label behavior, add the renderValue example and API row, and document the label fallback used by the selected display. No unrelated change is demonstrated.

Full details: Linked Issues check

Explanation

Issue [#2248] requires both documentation and a published Select.Trigger type that accepts renderValue(value, label). The PR adds the custom-value section, example, default selected-label explanation, and API row. The PR does not change the published type. SelectTriggerProps still derives from React.ComponentPropsWithoutRef<typeof ComboboxPrimitive.Trigger> in src/components/ui/Select/fragments/SelectTrigger.tsx. The documented usage therefore does not establish that the reported published-types error is fixed.

Resolution

Add renderValue to the published Select.Trigger props. Resolve the ComboboxPrimitive type export or import path used by the published declarations if it prevents that prop from being emitted. Add or update an automated type check for the documented usage.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Full details: Title check

Explanation

The title claims that the change preserves trigger callback types, but the pull request primarily adds Select documentation, a renderValue example, and API reference details for custom trigger values.

Resolution

Rename the pull request to describe the documentation change, such as docs(select): explain custom trigger values.

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-20T08:25:33Z

Coverage

This report compares the PR with the base branch. "Δ" shows how the PR affects each metric.

Metric	PR	Δ
Statements	85.71%	-0.03%
Branches	71.07%	+0.00%
Functions	77.87%	-0.07%
Lines	87.57%	-0.03%

Coverage decreased for at least one metric. Please add or update tests to improve coverage.

Run npm run coverage:ci locally for detailed reports and target untested areas to raise these numbers.

docs(select): explain custom trigger values

3be0f27

kotAPI added codex codex-automation labels Oct 18, 2026

fix(select): preserve trigger callback types

fb211eb

kotAPI changed the title ~~docs(select): explain custom trigger values~~ fix(select): preserve trigger callback types Oct 18, 2026

kotAPI added 3 commits October 18, 2026 12:15

fix(select): preserve typed data attributes

b4e6d97

fix(select): preserve custom trigger props

f617a24

Merge branch 'main' into docs/select-render-value

7c5cf9b

kotAPI mentioned this pull request Oct 21, 2026

test(combobox): force-mounted focus-return test is flaky on CI #2274

Open

Merge branch 'main' into docs/select-render-value

0b6b925

Navigation Menu

Repository navigation

fix(select): preserve trigger callback types - #2261

fix(select): preserve trigger callback types#2261
kotAPI wants to merge 6 commits into
mainfrom
docs/select-render-value

kotAPI commented Oct 18, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 18, 2026 •

edited

Loading

Review limit reached

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kotAPI commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

github-actions Bot commented Oct 20, 2026

Coverage

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kotAPI commented Oct 18, 2026 •

edited

Loading

changeset-bot Bot commented Oct 18, 2026 •

edited

Loading

coderabbitai Bot commented Oct 18, 2026 •

edited

Loading