Repository navigation
Update make-image-release to use mtools and add a Github unit test - #920
Merged
Merged
Conversation
Convert make-recovery-images to build the Raspberry Pi Imager disk images entirely in user space, following the approach already used by make-pi4-rpiboot-gpio-sd. The FAT32 partition is created with mkfs.fat on a partition image, populated with mcopy and spliced into the sfdisk-partitioned disk image with dd. This removes the dependency on kpartx, loopback devices, mount and the sleep workarounds for orphaned loop devices, and the root / SUDO_UID checks and chown calls. The partition layout, disk identifier and FAT32 parameters are unchanged. make-imager-release no longer invokes make-recovery-images via sudo.
Add test/test-make-recovery-images which builds the 2711 and 2712 rpi-boot-eeprom-recovery release zips with imager/make-release, converts them with imager/make-recovery-images and verifies the output: * Image size, MBR disk identifier and the single FAT32 LBA partition (start 2048, 524288 sectors, type 0xc). * FAT32 BPB: 512 byte sectors, 1 sector per cluster, FAT32 type string and boot signature, cross-checked against minfo. * Loopback comparison: every file in the FAT filesystem is byte-identical to the source zip and the file set matches exactly. * recovery.bin and vl805.bin are identical to the firmware in the repository, pieeprom.bin and vl805.bin match their .sig digests and the EEPROM image is readable with rpi-eeprom-config with the boot.conf for the sd / usb / network variant. Run the test as a separate job in the GitHub Actions workflow and document it in test/README.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.