Repository navigation
Wait for OpenNext note persistence before checking database writes - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenNext browser test shares a D1 database across Chromium and WebKit. Both saved the same note value, so the second engine could satisfy the DOM assertion using the first engine’s value before its POST completed, then observe the previous write count.
Use an engine-specific note value and register the POST response wait before clicking Save. Require the 303 response, rendered value and exactly one database write; no assertions are removed or retried.
Validation: the full OpenNext integration test passed locally in Chromium and WebKit. Manager and independent acceptance reviews passed. This is a test-only correction discovered during 0.1.7 release validation; the immutable v0.1.7 tag is unchanged. Its original failure and unchanged-candidate rerun are recorded separately from this fix.
Final CI: Compatibility and all CodeQL language analyses passed at b7c1c7b. The first Inkstone Android attempt lost its emulator (the saved diagnostic says
adb: device emulator-5554 not found) after registration returned 201, so no acceptance report arrived. The unchanged-commit retry passed all required contracts. Both attempts and native diagnostics are retained under artifacts/validation/pr74; no assertion was skipped or weakened.