Repository navigation
feat(r-packages)!: install system requirements in two phases by default - #286
Merged
Merged
Conversation
- `installSystemRequirements` now defaults to `true` - System requirements are installed by root with the commands generated by `pak::pkg_sysreqs()` run as the user, so that it does not depend on `sudo` at build time - R packages are installed by the user with `PKG_SYSREQS=false` - Use randomly named temporary directories and remove them on exit
pak no longer works on CentOS 7 (glibc 2.17).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #284. Applies the same system requirements installation as r-rig v2 to the r-packages Feature (v2.0.0, breaking change).
Changes
installSystemRequirementsnow defaults totrue.sudobeing available at build time:pak::pkg_sysreqs()(afterpak::repo_add()) and writes the install commands into a user-owned temporary directory.The build fails if this step fails.
The commands are generated by pak for the platform, so non-apt platforms supported by pak keep working.
PKG_SYSREQS=false, then runspak::cache_clean()andpak::meta_clean(force = TRUE).NOT_CRAN,PKG_CRAN_MIRROR, etc.) are set explicitly in thesucommand.additionalRepositoriesis passed to R via a root-owned file to avoid quoting problems.mktemp -dand removed on exit.installSystemRequirements: false.