Skip to content

Centralize bound universe computation in inductive types - #22176

Merged
coqbot-app[bot] merged 3 commits into
rocq-prover:masterfrom
ppedrot:template-extrude-univ-subst-further
Jun 29, 2026
Merged

coqbot-app[bot] merged 3 commits into
rocq-prover:masterfrom
ppedrot:template-extrude-univ-subst-further

Conversation

@ppedrot

@ppedrot ppedrot commented Jun 27, 2026

Copy link
Copy Markdown
Member

Follow-up of #22070. We now perform the universe substitution first, and only once. All internal functions work directly on the abstracted representation rather than mixing both. This PR does not touch the API and should be 100% backwards compatible, and is thus submitted separately from a yet-to-come API-tweaking cleanup PR.

@ppedrot ppedrot added this to the 9.3+rc1 milestone Jun 27, 2026
@ppedrot
ppedrot requested a review from a team as a code owner June 27, 2026 14:03
@ppedrot ppedrot added kind: cleanup Code removal, deprecation, refactorings, etc. request: full CI Use this label when you want your next push to trigger a full CI. labels Jun 27, 2026
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jun 27, 2026
@ppedrot

ppedrot commented Jun 27, 2026

Copy link
Copy Markdown
Member Author

Interesting error that doesn't seem related to this PR in native compilation: https://gitlab.inria.fr/coq/coq/-/jobs/7519530.

@SkySkimmer

Copy link
Copy Markdown
Contributor

I guess we don't catch the right error at

| exception (Sys_error _ as e) ->

@SkySkimmer SkySkimmer self-assigned this Jun 29, 2026
@SkySkimmer

Copy link
Copy Markdown
Contributor

@coqbot merge now

@coqbot-app
coqbot-app Bot merged commit 50784f7 into rocq-prover:master Jun 29, 2026
9 checks passed
@ppedrot
ppedrot deleted the template-extrude-univ-subst-further branch June 29, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: cleanup Code removal, deprecation, refactorings, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants