Repository navigation
Centralize bound universe computation in inductive types - #22176
Merged
coqbot-app[bot] merged 3 commits intoJun 29, 2026
Merged
coqbot-app[bot] merged 3 commits into
coqbot-app[bot] merged 3 commits into
Conversation
Member
Author
|
Interesting error that doesn't seem related to this PR in native compilation: https://gitlab.inria.fr/coq/coq/-/jobs/7519530. |
Contributor
|
I guess we don't catch the right error at Line 156 in 5de4c20 |
SkySkimmer
approved these changes
Jun 29, 2026
Contributor
|
@coqbot merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #22070. We now perform the universe substitution first, and only once. All internal functions work directly on the abstracted representation rather than mixing both. This PR does not touch the API and should be 100% backwards compatible, and is thus submitted separately from a yet-to-come API-tweaking cleanup PR.