Repository navigation
Conversation
The #[Group('functional')] attribute was missing its closing quote, so the
description was swallowed into the group name. Base::setUp then rejected the
test as having no group, and CI's group runs skipped it. Move the description
into the docblock and close the attribute.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MappingTest::testDynamicTemplatehas a malformed attribute. The closing quote is missing from#[Group('functional, so the description text is swallowed into the group name.Base::setUpthen rejects the test with "Every test must have one of unit, functional, benchmark group", and CI's--group functionalrun never picks it up.This moves the description into the docblock and closes the attribute as
#[Group('functional')]. The test now runs in CI's functional group.Red then green
make docker-run-phpunit PHPUNIT_OPTIONS="--filter=testDynamicTemplate"fails withEvery test must have one of "unit", "functional", "benchmark" group.OK (1 test, 4 assertions)) against ES 9.5.5.This is a test-only change with no
src/fix, so the red/green rule in AGENTS.md doesn't apply directly.Verification
make docker-run-phpunit, no group filter): the only failures left areJSONTestandAbstractSimpleAggregationTest, which have their own PRs. This test passes.No CHANGELOG entry: test-only.