Skip to content

test: fix malformed group attribute on MappingTest::testDynamicTemplate - #2331

Open
ruflin wants to merge 1 commit into
9.xfrom
fix/mapping-test-group
Open

ruflin wants to merge 1 commit into
9.xfrom
fix/mapping-test-group

Conversation

@ruflin

@ruflin ruflin commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

MappingTest::testDynamicTemplate has a malformed attribute. The closing quote is missing from #[Group('functional, so the description text is swallowed into the group name. Base::setUp then rejects the test with "Every test must have one of unit, functional, benchmark group", and CI's --group functional run never picks it up.

This moves the description into the docblock and closes the attribute as #[Group('functional')]. The test now runs in CI's functional group.

Red then green

  • Before: make docker-run-phpunit PHPUNIT_OPTIONS="--filter=testDynamicTemplate" fails with Every test must have one of "unit", "functional", "benchmark" group.
  • After: the same command passes (OK (1 test, 4 assertions)) against ES 9.5.5.

This is a test-only change with no src/ fix, so the red/green rule in AGENTS.md doesn't apply directly.

Verification

  • Full suite (make docker-run-phpunit, no group filter): the only failures left are JSONTest and AbstractSimpleAggregationTest, which have their own PRs. This test passes.
  • PHP-CS-Fixer and PHPStan pass.

No CHANGELOG entry: test-only.

The #[Group('functional')] attribute was missing its closing quote, so the
description was swallowed into the group name. Base::setUp then rejected the
test as having no group, and CI's group runs skipped it. Move the description
into the docblock and close the attribute.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant