Repository navigation
Conversation
createMock() stubs every method, including toArray(), which is the method under test. The mock returned null, so the expected InvalidException was never thrown. The class also overrode setUp() without calling parent::setUp(), which skipped Base::setUp's group check, and it declared no group. Call the parent setUp and declare the unit group so CI runs it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractSimpleAggregationTestbuilt its subject withcreateMock(AbstractSimpleAggregation::class). PHPUnit stubs every method on a mock, includingtoArray(), which is the method under test. The stub returned nothing, so the expectedInvalidExceptionwas never thrown.The fix uses a real anonymous subclass with no params set, so
toArray()runs its own validation. Two related gaps are fixed too:setUp()without callingparent::setUp(), which skippedBase::setUp's group check.It now calls the parent
setUp()and declares#[Group('unit')].Red then green
--filter=AbstractSimpleAggregationTestfails withFailed asserting that exception of type "Elastica\Exception\InvalidException" is thrown.OK (1 test, 3 assertions)).This is a test-only change with no
src/fix, so the red/green rule in AGENTS.md doesn't apply directly.Verification
make docker-run-phpunit): this test passes. The remaining failures areMappingTestandJSONTest, which have their own PRs.No CHANGELOG entry: test-only.