Skip to content

next solver stress benchmark - #2601

Merged
Kobzol merged 11 commits into
rust-lang:mainfrom
amirHdev:next-solver-stress-benchmark
Nov 16, 2026
Merged

Kobzol merged 11 commits into
rust-lang:mainfrom
amirHdev:next-solver-stress-benchmark

Conversation

@amirHdev

@amirHdev amirHdev commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

@amirHdev
amirHdev force-pushed the next-solver-stress-benchmark branch 2 times, most recently from e2bf57e to 8c5a26e Compare September 30, 2026 09:40
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@amirHdev
amirHdev force-pushed the next-solver-stress-benchmark branch from 8c5a26e to 378da17 Compare October 1, 2026 07:43
@amirHdev
amirHdev marked this pull request as ready for review October 1, 2026 08:26
@panstromek

panstromek commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Is this waiting for some input from wg-compiler-performance, or are you still collecting repro cases for it? I think it'd be nice to get this merged, because it patches a blind spot in the suite.

@amirHdev

Copy link
Copy Markdown
Contributor Author

Is this waiting for some input from wg-compiler-performance, or are you still collecting repro cases for it? I think it'd be nice to get this merged, because it patches a blind spot in the suite.

Thanks for checking in!
this isn't waiting on input from wg-compiler-performance and I'm not planning to hold it for additional repro cases

I think the current set covers the intended scope
any additional cases can be added in follow-up PRs.

@panstromek panstromek left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but I'll ask @Kobzol for an opinion as well (I don't feel 100% qualified to do the final stamp on adding new benchmark 😄)

Comment on lines +5 to +8
"excluded_profiles": [
"Doc",
"DocJson"
],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe not exclude those. doc builds sometimes stress different parts of the type system machinery than the other build types.

@panstromek
panstromek requested a review from Kobzol November 16, 2026 14:32
@panstromek

Copy link
Copy Markdown
Contributor

I forgot to ask - how long does it take to compile this stress test atm?

@amirHdev

Copy link
Copy Markdown
Contributor Author

@panstromek compilation takes around 3.5s on my M3 Mac using nightly Rust

@Kobzol

Kobzol commented Nov 16, 2026

Copy link
Copy Markdown
Member

Any reason to exclude the incremental cases? I'd keep everything by default, unless it takes a very long time to compile (which this one likely doesn't).

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@amirHdev

Copy link
Copy Markdown
Contributor Author

Any reason to exclude the incremental cases? I'd keep everything by default, unless it takes a very long time to compile (which this one likely doesn't).

I initially excluded them to keep the test scope smaller
I removed the exclude part

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's try it in full. Right now, we have ~4 minutes to spare on the second collector anyway. Thank you!

@Kobzol
Kobzol enabled auto-merge November 16, 2026 17:27
@Kobzol
Kobzol added this pull request to the merge queue Nov 16, 2026
Merged via the queue into rust-lang:main with commit 30d0ded Nov 16, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants