Repository navigation
next solver stress benchmark - #2601
Conversation
e2bf57e to
8c5a26e
Compare
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
8c5a26e to
378da17
Compare
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
|
Is this waiting for some input from wg-compiler-performance, or are you still collecting repro cases for it? I think it'd be nice to get this merged, because it patches a blind spot in the suite. |
Thanks for checking in! I think the current set covers the intended scope |
There was a problem hiding this comment.
Good, but I'll ask @Kobzol for an opinion as well (I don't feel 100% qualified to do the final stamp on adding new benchmark 😄)
| "excluded_profiles": [ | ||
| "Doc", | ||
| "DocJson" | ||
| ], |
There was a problem hiding this comment.
I'd maybe not exclude those. doc builds sometimes stress different parts of the type system machinery than the other build types.
|
I forgot to ask - how long does it take to compile this stress test atm? |
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
|
@panstromek compilation takes around 3.5s on my M3 Mac using nightly Rust |
|
Any reason to exclude the incremental cases? I'd keep everything by default, unless it takes a very long time to compile (which this one likely doesn't). |
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
I initially excluded them to keep the test scope smaller |
Kobzol
left a comment
There was a problem hiding this comment.
Yeah, let's try it in full. Right now, we have ~4 minutes to spare on the second collector anyway. Thank you!
includes a
next-solver-stressbenchmark with repros for:c2eparser-combinator repro)randand opaque types trait-system-refactor-initiative#267#159933 is the test case related to rust-lang/rust#161348