Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
289 changes: 289 additions & 0 deletions triage/2026/2026-11-15.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,289 @@
# 2026-11-16 Triage Log

A generally positive week, with improvements significantly outweighing
regressions for an average of -1.1% instructions on primary benchmarks.

Triage done by **@simulacrum**.
Revision range: [54d0b7ed..6ca2b346](https://perf.rust-lang.org/?start=54d0b7edad511e84181ad50ec8413ef10f93b367&end=6ca2b34602bf2f3591ffa7359c166b6409a44b0a&absolute=false&stat=instructions%3Au)

**Summary**:

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.8% | [0.2%, 6.0%] | 21 |
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 35 |
| Improvements ✅ <br /> (primary) | -1.3% | [-5.3%, -0.2%] | 154 |
| Improvements ✅ <br /> (secondary) | -1.2% | [-4.2%, -0.1%] | 192 |
| All ❌✅ (primary) | -1.1% | [-5.3%, 6.0%] | 175 |

5 Regressions, 12 Improvements, 4 Mixed; 0 of them in rollups
147 artifact comparisons made in total

#### Regressions

Prepare to make `rustc_trivial_field_reads` usable in user code [#164217](https://github.com/rust-lang/rust/pull/164217) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b6c79e88af6825838aed7c6a159e7e0b00259443&end=b076b102716c2faf55d3d88e74b01bb431def7eb&stat=instructions:u)
Merged as part of rollup [#165760](https://github.com/rust-lang/rust/pull/165760)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.3%] | 16 |
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.9%] | 21 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 2 |
| All ❌✅ (primary) | 0.2% | [0.1%, 0.3%] | 16 |

Not entirely clear how real the regressions are -- the rollup this landed in
contained other regressing PRs, so hard to look at history and tell. The
regressions seem likely to be unavoidable if we are polishing a new user-facing
feature used by Debug and other common derives, though, if I'm interpreting
what this PR does correctly (the description is not super clear IMO). As such
going to mark this as triaged from a perf perspective, I don't see follow up
yielding interesting results.

`Move` trait feature gate [#165569](https://github.com/rust-lang/rust/pull/165569) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b6c79e88af6825838aed7c6a159e7e0b00259443&end=98ea6740c5e0b398dfca2cb0deb5995886291c1c&stat=instructions:u)
Merged as part of rollup [#165760](https://github.com/rust-lang/rust/pull/165760)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:----:|:------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.3% | [0.1%, 0.6%] | 13 |
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.5%] | 8 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.3% | [0.1%, 0.6%] | 13 |

Regressions seem expected and largely unavoidable for touching code that's
commonly exercised without the feature gate, and magnitude is not particularly
large.

fix incorrect byte count suffix on MSVC [#165458](https://github.com/rust-lang/rust/pull/165458) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b6c79e88af6825838aed7c6a159e7e0b00259443&end=ceb2a180e363ac2effac67b53cc18e35bd9935f0&stat=instructions:u)
Merged as part of rollup [#165760](https://github.com/rust-lang/rust/pull/165760)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:----:|:------------:|:-----:|
| Regressions ❌ <br /> (primary) | 1.1% | [0.2%, 3.6%] | 35 |
| Regressions ❌ <br /> (secondary) | 1.4% | [0.1%, 9.1%] | 48 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | 1.1% | [0.2%, 3.6%] | 35 |

Correctness fix, but shouldn't have had impact on Linux. This has since been
reverted in [#165856](https://github.com/rust-lang/rust/pull/165856) pending a
performance fix.

Revert #164014 (noop &T -> &T reborrows) [#165801](https://github.com/rust-lang/rust/pull/165801) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e88737b98536eae309f98e207b8af6a2cafa0350&end=9f5e966d58e5cdf21160ba12907661b0720e8c69&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.7% | [0.2%, 4.1%] | 158 |
| Regressions ❌ <br /> (secondary) | 1.5% | [0.1%, 7.5%] | 106 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -0.6% | [-0.6%, -0.5%] | 2 |
| All ❌✅ (primary) | 0.7% | [0.2%, 4.1%] | 158 |

Revert carries expected regression; a future re-land will reintroduce
improvements once the remaining blockers are resolved.

view-types: lower view types from HIR [#165565](https://github.com/rust-lang/rust/pull/165565) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d3622156fd2c96d8653efd3868341978763d63bc&end=885e31b6687683b7920d3ae8d25f6bdcc4ba850c&stat=instructions:u)
Merged as part of rollup [#165918](https://github.com/rust-lang/rust/pull/165918)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.3%] | 2 |
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.3%] | 26 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.2%] | 1 |
| All ❌✅ (primary) | 0.2% | [0.2%, 0.3%] | 2 |

This is making only rustdoc a little slower. It's not clear why at this time,
but given the magnitude of the regressions and being limited mostly to
secondary benchmarks (with exception of helloworld), likely not worth further
investigation.

#### Improvements

skip reachable_set calculation during metadata encoding when unused [#165602](https://github.com/rust-lang/rust/pull/165602) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4de0e38612353dc524009a12ad43f0c05a5f8c6e&end=fd4400dce238d263ff4239ac9eb902cb9547daf2&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -0.8% | [-5.5%, -0.2%] | 36 |
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.7%, -0.1%] | 14 |
| All ❌✅ (primary) | -0.8% | [-5.5%, -0.2%] | 36 |


Restore the fast path of `QueryTypeOp` [#165672](https://github.com/rust-lang/rust/pull/165672) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=495625e3cba369dad96c4d1e8030e8fe1816ab2c&end=fefe61bee03e8d6ff1f3f16bcedc8cb05e3f7bf3&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -1.1% | [-3.4%, -0.2%] | 115 |
| Improvements ✅ <br /> (secondary) | -1.4% | [-3.9%, -0.2%] | 128 |
| All ❌✅ (primary) | -1.1% | [-3.4%, -0.2%] | 115 |


Avoid repeated gated spans snapshots during macro matching [#165663](https://github.com/rust-lang/rust/pull/165663) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fefe61bee03e8d6ff1f3f16bcedc8cb05e3f7bf3&end=713ca2a7751f287b4a6a65bc09486df2e5c07719&stat=instructions:u)
Merged as part of rollup [#165698](https://github.com/rust-lang/rust/pull/165698)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -1.2% | [-3.1%, -0.2%] | 23 |
| Improvements ✅ <br /> (secondary) | -0.4% | [-1.4%, -0.1%] | 19 |
| All ❌✅ (primary) | -1.2% | [-3.1%, -0.2%] | 23 |


Don't emit no-op `&T` → `&T` reborrows [#164014](https://github.com/rust-lang/rust/pull/164014) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ac8310ba643a3796cbe77d2e06944d7c8513999f&end=b6c79e88af6825838aed7c6a159e7e0b00259443&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -0.7% | [-3.9%, -0.2%] | 171 |
| Improvements ✅ <br /> (secondary) | -1.5% | [-7.0%, -0.0%] | 108 |
| All ❌✅ (primary) | -0.7% | [-3.9%, -0.2%] | 171 |


Move `check_attr` to attribute parsing [#165693](https://github.com/rust-lang/rust/pull/165693) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b6c79e88af6825838aed7c6a159e7e0b00259443&end=35009185033f8f7f7dcc1b6bfe7b68c3d1bf891b&stat=instructions:u)
Merged as part of rollup [#165760](https://github.com/rust-lang/rust/pull/165760)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.4%, -0.1%] | 10 |
| All ❌✅ (primary) | - | - | 0 |


Replace `match_span_kind` macro with `SpanKind` [#165805](https://github.com/rust-lang/rust/pull/165805) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9f5e966d58e5cdf21160ba12907661b0720e8c69&end=acd4224e578033cb6a801874f8ef1b6b693e2f7d&stat=instructions:u)
Merged as part of rollup [#165821](https://github.com/rust-lang/rust/pull/165821)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 2 |
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 2 |
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.7%, -0.2%] | 37 |
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 2 |


Add support for `annotate-snippets`'s `no-graphics` output format [#165708](https://github.com/rust-lang/rust/pull/165708) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6b05f82b4f2d1309cdbddece388c9e4d26f481fc&end=b4fe65c19d1bb6e720c843086b785493c453028d&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 1 |
| Improvements ✅ <br /> (primary) | -1.4% | [-3.1%, -0.3%] | 22 |
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.7%, -0.2%] | 27 |
| All ❌✅ (primary) | -1.4% | [-3.1%, -0.3%] | 22 |


Revert "fix incorrect byte count suffix on MSVC" [#165856](https://github.com/rust-lang/rust/pull/165856) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b4fe65c19d1bb6e720c843086b785493c453028d&end=29a5d066d98b58d948d285ba22390a5f849f5938&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -1.1% | [-3.6%, -0.2%] | 35 |
| Improvements ✅ <br /> (secondary) | -1.4% | [-8.4%, -0.3%] | 43 |
| All ❌✅ (primary) | -1.1% | [-3.6%, -0.2%] | 35 |


avoid deep resolution for trivially sized goals [#164349](https://github.com/rust-lang/rust/pull/164349) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=75bb7a374ff3f5363432a17e8000b50a60a4530c&end=d3622156fd2c96d8653efd3868341978763d63bc&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -1.1% | [-1.7%, -0.3%] | 10 |
| All ❌✅ (primary) | - | - | 0 |


reflection: reflect attributes from adts, fields, and variants [#165810](https://github.com/rust-lang/rust/pull/165810) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d3622156fd2c96d8653efd3868341978763d63bc&end=9b241afb57118d4bdf485a8a147cdcf159abd3da&stat=instructions:u)
Merged as part of rollup [#165918](https://github.com/rust-lang/rust/pull/165918)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 4 |
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 4 |


Some attribute related cleanups [#165872](https://github.com/rust-lang/rust/pull/165872) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d3622156fd2c96d8653efd3868341978763d63bc&end=1c1aa3f6324c697d2d5b78f3d3df161f5c8cce15&stat=instructions:u)
Merged as part of rollup [#165918](https://github.com/rust-lang/rust/pull/165918)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 4 |
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 4 |


#### Mixed

`rustc_builtin_macros` cleanup, part 9 [#165161](https://github.com/rust-lang/rust/pull/165161) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fefe61bee03e8d6ff1f3f16bcedc8cb05e3f7bf3&end=f91f1a6db568fd9e9f2bfc69f344eba48f6435f2&stat=instructions:u)
Merged as part of rollup [#165698](https://github.com/rust-lang/rust/pull/165698)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.3%] | 4 |
| Regressions ❌ <br /> (secondary) | 0.0% | [0.0%, 0.0%] | 1 |
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 3 |
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.1%] | 8 |
| All ❌✅ (primary) | 0.1% | [-0.2%, 0.3%] | 7 |

Already triaged:

> Matches expectation
> The libc incremental regressions weren't present in the original benchmark run, but I don't think those are worth looking in to.

- <https://github.com/rust-lang/rust/pull/165161#issuecomment-6751676933>

[rustdoc] Render `Deref` methods on aliased items [#163571](https://github.com/rust-lang/rust/pull/163571) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fefe61bee03e8d6ff1f3f16bcedc8cb05e3f7bf3&end=55d4d536c7affe668cf7c841b69639a26fc3c00f&stat=instructions:u)
Merged as part of rollup [#165698](https://github.com/rust-lang/rust/pull/165698)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 2.6% | [0.7%, 6.0%] | 5 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -1.7% | [-1.7%, -1.7%] | 1 |
| All ❌✅ (primary) | 2.6% | [0.7%, 6.0%] | 5 |

Seems expected that this would cause regressions for (presumably) crates containing such items. Marking as triaged.

add `core::arch::{x86, x86_64}::x87_f80` [#163992](https://github.com/rust-lang/rust/pull/163992) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b6c79e88af6825838aed7c6a159e7e0b00259443&end=ff26eab81ea83c3cd8f47c2f36b03ca18ec4c751&stat=instructions:u)
Merged as part of rollup [#165760](https://github.com/rust-lang/rust/pull/165760)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 3 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 4 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | -0.0% | [-0.3%, 0.2%] | 7 |

Standard-ish sporadic regressions from larger standard library API surface area
and slightly more complex code in various float-touching paths in the compiler
to support the new types.

Change the span building of paths from first-to-last to chained [#165047](https://github.com/rust-lang/rust/pull/165047) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b6c79e88af6825838aed7c6a159e7e0b00259443&end=6842318cddf906241ca2f42dac8e806ac7d6a8ec&stat=instructions:u)
Merged as part of rollup [#165760](https://github.com/rust-lang/rust/pull/165760)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 3 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 1 |
| All ❌✅ (primary) | 0.2% | [0.2%, 0.2%] | 3 |

Regressions are acceptably small for what looks like a correctness fix.
Loading