Skip to content

Have the bot post a message when it marks a PR as "ready for review" because it got un-drafted #2555

Closed

Description

@RalfJung

Currently, if a PR author marks a draft PR as "ready", the bot uses that as a signal to update the label to "ready for review". However, no notification is sent, so as reviewer I have no idea that this happened.

Would be nice if the bot could post a message, so that I can a way to track this via my email inbox.

Activity

  1. Kobzol commented on Nov 8, 2026

    @Kobzol
    Member

    It indeed does happen quite often to me that a PR was undrafted, but I had no idea about it. It would be nice if triagebot only sent a notification if it doesn't send any other comment in reaction to the undrafting, maybe?

  2. RalfJung commented on Nov 8, 2026

    @RalfJung
    MemberAuthor

    Well, in my case it sent the auto-assign-no-one message (which was a bit silly since the PR was previously ready, then draft, then ready again, but okay). I did not realize that this means "please review again". So I don't think the auto-assign-no-one message should suppress the "ready" message. But of course they could be combined into one.

  3. Urgau commented on Nov 8, 2026

    @Urgau
    Member

    IMO this seems like something we should report to GitHub directly. Maybe open a issue in our GitHub feedback repo.

  4. Kobzol commented on Nov 8, 2026

    @Kobzol
    Member

    https://github.com/orgs/community/discussions/158714 that has likely been done already a couple of times, but it doesn't seem like GitHub heeds it. As with many other things, we'd have to provide our own workaround if we want to fix this.

  5. RalfJung commented on Nov 8, 2026

    @RalfJung
    MemberAuthor

    IMO this seems like something we should report to GitHub directly. Maybe open a issue in our GitHub feedback repo.

    Fully agreed. Just like proper handling of force pushes.
    Sadly, Github doesn't give us either, so we can either wait or have our own tooling fill the gaps.

  6. Urgau commented on Nov 9, 2026

    @Urgau
    Member

    I assume you would also want this notification from triagebot for the other way, ready to draft?

    Would it make sense to auto-hide this "notification"/comment, to limit a bit the visual spam?

  7. RalfJung commented on Nov 9, 2026

    @RalfJung
    MemberAuthor

    I assume you would also want this notification from triagebot for the other way, ready to draft?

    Not really, no. Drafts are not my responsibility so it doesn't matter if I lose track of one.

    Would it make sense to auto-hide this "notification"/comment, to limit a bit the visual spam?

    No opinion either way. Is this something we do for other comments?

  8. Urgau commented on Nov 9, 2026

    @Urgau
    Member

    Would it make sense to auto-hide this "notification"/comment, to limit a bit the visual spam?

    No opinion either way. Is this something we do for other comments?

    We sometimes hide some comments when the information is no longer accurate. Like when we post a warning, if it's resolved we hide the comment.

    This would be a bit different though, since we would post and insta-hide the comment.

  9. RalfJung commented on Nov 9, 2026

    @RalfJung
    MemberAuthor

    Seems worth a try, yeah.

  10. Urgau commented on Nov 11, 2026

    @Urgau
    Member

    Implemented in #2560

  11. RalfJung commented on Nov 11, 2026

    @RalfJung
    MemberAuthor

    And it is working. Thanks a lot @Urgau :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions