You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Have the bot post a message when it marks a PR as "ready for review" because it got un-drafted #2555
Currently, if a PR author marks a draft PR as "ready", the bot uses that as a signal to update the label to "ready for review". However, no notification is sent, so as reviewer I have no idea that this happened.
Would be nice if the bot could post a message, so that I can a way to track this via my email inbox.
It indeed does happen quite often to me that a PR was undrafted, but I had no idea about it. It would be nice if triagebot only sent a notification if it doesn't send any other comment in reaction to the undrafting, maybe?
Well, in my case it sent the auto-assign-no-one message (which was a bit silly since the PR was previously ready, then draft, then ready again, but okay). I did not realize that this means "please review again". So I don't think the auto-assign-no-one message should suppress the "ready" message. But of course they could be combined into one.
https://github.com/orgs/community/discussions/158714 that has likely been done already a couple of times, but it doesn't seem like GitHub heeds it. As with many other things, we'd have to provide our own workaround if we want to fix this.
IMO this seems like something we should report to GitHub directly. Maybe open a issue in our GitHub feedback repo.
Fully agreed. Just like proper handling of force pushes.
Sadly, Github doesn't give us either, so we can either wait or have our own tooling fill the gaps.
Activity
Kobzol commentedon Nov 8, 2026
It indeed does happen quite often to me that a PR was undrafted, but I had no idea about it. It would be nice if triagebot only sent a notification if it doesn't send any other comment in reaction to the undrafting, maybe?
RalfJung commentedon Nov 8, 2026
Well, in my case it sent the auto-assign-no-one message (which was a bit silly since the PR was previously ready, then draft, then ready again, but okay). I did not realize that this means "please review again". So I don't think the auto-assign-no-one message should suppress the "ready" message. But of course they could be combined into one.
Urgau commentedon Nov 8, 2026
IMO this seems like something we should report to GitHub directly. Maybe open a issue in our GitHub feedback repo.
Kobzol commentedon Nov 8, 2026
https://github.com/orgs/community/discussions/158714 that has likely been done already a couple of times, but it doesn't seem like GitHub heeds it. As with many other things, we'd have to provide our own workaround if we want to fix this.
RalfJung commentedon Nov 8, 2026
Fully agreed. Just like proper handling of force pushes.
Sadly, Github doesn't give us either, so we can either wait or have our own tooling fill the gaps.
Urgau commentedon Nov 9, 2026
I assume you would also want this notification from triagebot for the other way, ready to draft?
Would it make sense to auto-hide this "notification"/comment, to limit a bit the visual spam?
RalfJung commentedon Nov 9, 2026
Not really, no. Drafts are not my responsibility so it doesn't matter if I lose track of one.
No opinion either way. Is this something we do for other comments?
Urgau commentedon Nov 9, 2026
We sometimes hide some comments when the information is no longer accurate. Like when we post a warning, if it's resolved we hide the comment.
This would be a bit different though, since we would post and insta-hide the comment.
RalfJung commentedon Nov 9, 2026
Seems worth a try, yeah.
Urgau commentedon Nov 11, 2026
Implemented in #2560
RalfJung commentedon Nov 11, 2026
And it is working. Thanks a lot @Urgau :)