Repository navigation
fix: parse quoted paths in git diffs - #2557
Merged
Merged
Conversation
Kobzol
reviewed
Nov 11, 2026
Decode Git C-style path quoting in file headers and rename metadata so non-ASCII and escaped filenames are not silently dropped.
ruturajr-raval
force-pushed
the
fix/quoted-diff-paths
branch
from
November 12, 2026 17:12
16cac70 to
bab65b0
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Kobzol
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2550.
Git quotes unusual paths with C-style escapes. The diff parser expected literal
a/andb/prefixes, so those files were silently omitted.This decodes quoted paths in
diff --git,rename from, andrename tolines without adding a dependency.Tests:
cargo test --locked --workspace --all-targetscargo fmt --all --checkAI-assisted; reviewed and validated by the author.