Repository navigation
fix(signal): use system OpenBLAS on Windows for the eigenvalue feature (port of #825) - #2530
Merged
Merged
Conversation
openblas-src rejects its static build on Windows ("Non-vcpkg builds are
not supported on Windows"), so a default-feature build of
wifi-densepose-signal could not compile there. Declare ndarray-linalg
per target: openblas-system on Windows, openblas-static elsewhere. Both
stay optional, so --no-default-features still drops BLAS entirely.
Ported from #825 by @PretaxE63, keeping the dependency optional (the
original made it unconditional, which re-added BLAS to every
default-features = false consumer) and dropping an unrelated
regenerated Tauri schema.
Co-authored-by: Uxsshann <usattha@gmail.com>
Co-Authored-By: claude-flow <ruv@ruv.net>
github-actions Bot
pushed a commit
to lucidiousgibs/RuView
that referenced
this pull request
Nov 12, 2026
…igenvalue feature (ruvnet#2530) openblas-src rejects its static build on Windows ("Non-vcpkg builds are not supported on Windows"), so a default-feature build of wifi-densepose-signal could not compile there. Declare ndarray-linalg per target: openblas-system on Windows, openblas-static elsewhere. Both stay optional, so --no-default-features still drops BLAS entirely. Ported from ruvnet#825 by @PretaxE63, keeping the dependency optional (the original made it unconditional, which re-added BLAS to every default-features = false consumer) and dropping an unrelated regenerated Tauri schema. Co-authored-by: Uxsshann <usattha@gmail.com> 48f8091
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #825 by @PretaxE63 (commit authored by the original author, plus a
Co-authored-bytrailer).Problem
openblas-srcrejects its static build on Windows (Non-vcpkg builds are not supported on Windows. You must use the 'system' feature.). Main pinsndarray-linalgwithopenblas-staticfor every target, so a default-feature build ofwifi-densepose-signal(eigenvalueon by default) fails on Windows. The CHANGELOG records this in the ADR-154 M2/M3 entries.Change
v2/Cargo.toml: remove the workspacendarray-linalgpin.wifi-densepose-signalis its only user.wifi-densepose-signal/Cargo.toml: declarendarray-linalgper target, bothoptional = true:cfg(windows)usesopenblas-systemopenblas-staticeigenvalue = ["ndarray-linalg"]is unchanged, so the public feature surface is the same.Differences from #825
The dependency stays optional. Fix Windows OpenBLAS backend selection for ndarray-linalg #825 declared the target-table deps as non-optional, which made
ndarray-linalgunconditional. Measured withcargo tree -p wifi-densepose-signal --no-default-features -i ndarray-linalgon the Fix Windows OpenBLAS backend selection for ndarray-linalg #825 head:ndarray-linalg v0.18.1withopenblas-systemopenblas-staticThat would have re-added BLAS to every
default-features = falseconsumer (sensing-server, cli, mat, train, engine, calibration, the python wheel) and undone the Windows-friendly--no-default-featurespath from Rust build errors #366/Build failure rust #415.The unrelated regenerated
wifi-densepose-desktop/gen/schemas/windows-schema.jsonhunk was dropped.Verification
cargo tree --workspace -e features --lockedwas run on main and on this branch, and the outputs were diffed:--no-default-featuresndarray-linalgx86_64-pc-windows-msvc,--no-default-featuresndarray-linalgx86_64-pc-windows-msvc, default featuresopenblas-static→openblas-system(ndarray-linalg, lax, openblas-src)--lockedpasses, andCargo.lockis unchanged.Not verified: an actual Windows link against a system/vcpkg OpenBLAS. No CI workflow builds the signal crate on Windows for PRs;
desktop-release.ymlis tag/dispatch-only. Only the feature resolution above was checked, plus the contributor's own report from #825 (Windows 11, vcpkg OpenBLAS installed). Windows users who build the defaulteigenvaluefeature now need a system OpenBLAS (e.g. vcpkg).--no-default-featuresremains the BLAS-free path.🤖 Generated with claude-flow