Skip to content

fix(signal): use system OpenBLAS on Windows for the eigenvalue feature (port of #825) - #2530

Merged
ruvnet merged 1 commit into
mainfrom
fix/windows-openblas-system-backend-825
Nov 11, 2026
Merged

ruvnet merged 1 commit into
mainfrom
fix/windows-openblas-system-backend-825

Conversation

@ruvnet

@ruvnet ruvnet commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Port of #825 by @PretaxE63 (commit authored by the original author, plus a Co-authored-by trailer).

Problem

openblas-src rejects its static build on Windows (Non-vcpkg builds are not supported on Windows. You must use the 'system' feature.). Main pins ndarray-linalg with openblas-static for every target, so a default-feature build of wifi-densepose-signal (eigenvalue on by default) fails on Windows. The CHANGELOG records this in the ADR-154 M2/M3 entries.

Change

  • v2/Cargo.toml: remove the workspace ndarray-linalg pin. wifi-densepose-signal is its only user.
  • wifi-densepose-signal/Cargo.toml: declare ndarray-linalg per target, both optional = true:
    • cfg(windows) uses openblas-system
    • every other target keeps openblas-static
  • eigenvalue = ["ndarray-linalg"] is unchanged, so the public feature surface is the same.

Differences from #825

Verification

cargo tree --workspace -e features --locked was run on main and on this branch, and the outputs were diffed:

Graph Diff vs main
Linux, default features 0 lines (identical)
Linux, --no-default-features 0 lines, no ndarray-linalg
x86_64-pc-windows-msvc, --no-default-features 0 lines, no ndarray-linalg
x86_64-pc-windows-msvc, default features only openblas-static → openblas-system (ndarray-linalg, lax, openblas-src)

--locked passes, and Cargo.lock is unchanged.

Not verified: an actual Windows link against a system/vcpkg OpenBLAS. No CI workflow builds the signal crate on Windows for PRs; desktop-release.yml is tag/dispatch-only. Only the feature resolution above was checked, plus the contributor's own report from #825 (Windows 11, vcpkg OpenBLAS installed). Windows users who build the default eigenvalue feature now need a system OpenBLAS (e.g. vcpkg). --no-default-features remains the BLAS-free path.

🤖 Generated with claude-flow

openblas-src rejects its static build on Windows ("Non-vcpkg builds are
not supported on Windows"), so a default-feature build of
wifi-densepose-signal could not compile there. Declare ndarray-linalg
per target: openblas-system on Windows, openblas-static elsewhere. Both
stay optional, so --no-default-features still drops BLAS entirely.

Ported from #825 by @PretaxE63, keeping the dependency optional (the
original made it unconditional, which re-added BLAS to every
default-features = false consumer) and dropping an unrelated
regenerated Tauri schema.

Co-authored-by: Uxsshann <usattha@gmail.com>
Co-Authored-By: claude-flow <ruv@ruv.net>
@ruvnet
ruvnet merged commit 48f8091 into main Nov 11, 2026
44 of 45 checks passed
@ruvnet
ruvnet deleted the fix/windows-openblas-system-backend-825 branch November 11, 2026 23:12
github-actions Bot pushed a commit to lucidiousgibs/RuView that referenced this pull request Nov 12, 2026
…igenvalue feature (ruvnet#2530)

openblas-src rejects its static build on Windows ("Non-vcpkg builds are
not supported on Windows"), so a default-feature build of
wifi-densepose-signal could not compile there. Declare ndarray-linalg
per target: openblas-system on Windows, openblas-static elsewhere. Both
stay optional, so --no-default-features still drops BLAS entirely.

Ported from ruvnet#825 by @PretaxE63, keeping the dependency optional (the
original made it unconditional, which re-added BLAS to every
default-features = false consumer) and dropping an unrelated
regenerated Tauri schema.

Co-authored-by: Uxsshann <usattha@gmail.com> 48f8091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants