Repository navigation
fix(wifi_densepose): repair broken facade — archive/v1 path, fail-loud get_latest_poses, honest packaging - #2547
Open
brandonrobertbrown wants to merge 1 commit into
Conversation
…ion swallow, repair packaging/urls
Author
|
Heads-up for maintainers: no workflow runs have registered on this PR (~35 min after opening). If the repo's Actions require approval for new-contributor forks, clicking Approve and run workflows will start CI. Happy to fix anything the checks turn up. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shipped
wifi_denseposePython facade broke during the v1 reorg (f49c722) and nobody noticed because nothing exercisesWiFiDensePose().start()end-to-end:wifi_densepose/__init__.pypointedsys.pathat<repo>/v1, which no longer exists (v1 now lives atarchive/v1), so the README Quick Start could only ever raiseImportErrorwith instructions referencing awifi-denseposedirectory that never existed in this repo layout.get_latest_poses()swallowed every exception (except Exception: return []/pass), making an unhealthy orchestrator indistinguishable from "no poses" — the opposite of the fail-closed doctrine documented inharness/ruview/README.md.pyproject.tomlstill packaged a top-levelsrc*tree and registeredsrc.cliconsole-script entry points for a module that no longer exists at the repo root, and pointed URLs at the retiredruvnet/wifi-denseposerepository.Changes
_v1_srcnow falls back toarchive/v1when top-levelv1/is absent (older checkouts keep working)._fetch_poses()propagates errors;get_latest_poses()logs a WARNING with traceback before returning[](documented:[]= no data yet, errors are never silent).include = ["wifi_densepose*"]only; deadsrc.clientry points removed with a pointer to the maintained Rust CLI inv2/crates/wifi-densepose-cli; URLs updated toruvnet/RuView.Test plan
py_compileclean on the facadearchive/v1is picked up and inserted intosys.pathpyproject.tomlre-lint