Skip to content

fix(wifi_densepose): repair broken facade — archive/v1 path, fail-loud get_latest_poses, honest packaging - #2547

Open
brandonrobertbrown wants to merge 1 commit into
ruvnet:mainfrom
brandonrobertbrown:fix/wifi-densepose-facade
Open

brandonrobertbrown wants to merge 1 commit into
ruvnet:mainfrom
brandonrobertbrown:fix/wifi-densepose-facade

Conversation

@brandonrobertbrown

Copy link
Copy Markdown

Summary

The shipped wifi_densepose Python facade broke during the v1 reorg (f49c722) and nobody noticed because nothing exercises WiFiDensePose().start() end-to-end:

  • wifi_densepose/__init__.py pointed sys.path at <repo>/v1, which no longer exists (v1 now lives at archive/v1), so the README Quick Start could only ever raise ImportError with instructions referencing a wifi-densepose directory that never existed in this repo layout.
  • get_latest_poses() swallowed every exception (except Exception: return [] / pass), making an unhealthy orchestrator indistinguishable from "no poses" — the opposite of the fail-closed doctrine documented in harness/ruview/README.md.
  • pyproject.toml still packaged a top-level src* tree and registered src.cli console-script entry points for a module that no longer exists at the repo root, and pointed URLs at the retired ruvnet/wifi-densepose repository.

Changes

  • _v1_src now falls back to archive/v1 when top-level v1/ is absent (older checkouts keep working).
  • ImportError message now gives the real repo-root install command.
  • _fetch_poses() propagates errors; get_latest_poses() logs a WARNING with traceback before returning [] (documented: [] = no data yet, errors are never silent).
  • Packaging: include = ["wifi_densepose*"] only; dead src.cli entry points removed with a pointer to the maintained Rust CLI in v2/crates/wifi-densepose-cli; URLs updated to ruvnet/RuView.

Test plan

  • py_compile clean on the facade
  • Path-resolution probe confirms archive/v1 is picked up and inserted into sys.path
  • Facade diff verified with a packaging-only pyproject.toml re-lint

@brandonrobertbrown

Copy link
Copy Markdown
Author

Heads-up for maintainers: no workflow runs have registered on this PR (~35 min after opening). If the repo's Actions require approval for new-contributor forks, clicking Approve and run workflows will start CI. Happy to fix anything the checks turn up.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant