Skip to content

Ignore bare numbers when detecting the language in search_dates #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdrianAtZyte wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Ignore bare numbers when detecting the language in search_dates #1466

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f4e505
Ignore bare numbers when detecting the language in search_dates
AdrianAtZyte Sep 28, 2026
3319cde
Merge remote-tracking branch 'origin/master' into search-bare-number-…
AdrianAtZyte Sep 30, 2026
c2c34f1
Use bare-number hits as a language detection tiebreaker
AdrianAtZyte Sep 30, 2026
95f0197
Ignore bare-number hits when no language has word hits
AdrianAtZyte Oct 2, 2026
af3b818
Merge remote-tracking branch 'origin/master' into search-bare-number-…
AdrianAtZyte Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions dateparser/languages/locale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,15 @@ def _count_words_present_in_the_dictionary(self, words, settings=None):
dict_cnt = 0
skip_cnt = 0
for word in set(words):
if word in dictionary:
# Some locales map bare numbers to months, e.g. "11" from the
# Vietnamese "tháng 11", which is no evidence of the language.
if word.isdigit():
skip_cnt += 1
elif word in dictionary:
if dictionary[word]:
dict_cnt += 1
else:
skip_cnt += 1
elif word.isdigit():
skip_cnt += 1
return [dict_cnt, skip_cnt]

@staticmethod
Expand Down
10 changes: 10 additions & 0 deletions tests/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,16 @@ def test_search_dates_returning_detected_languages_if_requested(
result = search_dates(text, add_detected_language=add_detected_language)
self.assertEqual(result, expected)

@parameterized.expand(
[
param(text="11 sent 12-Dec-2014"),
param(text="09 sent 12-Dec-2014"),
]
)
def test_search_dates_with_numbers_that_are_months_in_other_languages(self, text):
result = search_dates(text)
self.assertEqual(result, [("12-Dec-2014", datetime.datetime(2014, 12, 12))])

@parameterized.expand(
[
param(text="19 марта 2001", languages="wrong type: str instead of list"),
Expand Down
Loading